Skip to content

Conversation

@cgwalters
Copy link
Member

Got about halfway through reworking this for the recent change
to not encrypt by default (because of backwards compat concerns).

Got about halfway through reworking this for the recent change
to not encrypt by default (because of backwards compat concerns).
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2019
@cgwalters
Copy link
Member Author

/assign @darkmuggle
cc @ashcrow @miabbott

Copy link
Contributor

@darkmuggle darkmuggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgwalters
Copy link
Member Author

@darkmuggle This repo is Prow managed so needs an explicit /lgtm (and /approve)

@ashcrow
Copy link
Member

ashcrow commented Dec 10, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, darkmuggle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2019
@openshift-merge-robot openshift-merge-robot merged commit 18201b2 into openshift:master Dec 10, 2019
cgwalters added a commit to cgwalters/installer that referenced this pull request Dec 13, 2019
This has encryption/FIPS fixes.  Among other things, TPM2 binding
by default on metal is disabled by default.  See also
openshift/enhancements#140

Update: Now a regression causing partitioning to fail is fixed.

https://bugzilla.redhat.com/show_bug.cgi?id=1775388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants