Skip to content

CFE-757: Update changes made during Azure user tags implementation#1329

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
bharath-b-rh:cfe-757
Feb 9, 2023
Merged

CFE-757: Update changes made during Azure user tags implementation#1329
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
bharath-b-rh:cfe-757

Conversation

@bharath-b-rh
Copy link
Contributor

@bharath-b-rh bharath-b-rh commented Jan 31, 2023

Update enhancement proposal with the observations/changes made during the course of implementation.

  • DNS zones and records allows to add tags with keys having only letters, numbers, period, hyphen or underscore characters. And can end with only letters, numbers or an underscore.
  • Update the Infrastructure CRD content updated with more description for the new fields added.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023

@bharath-b-rh: This pull request references CFE-757 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bharath-b-rh bharath-b-rh changed the title WIP: CFE-757: Update changes made during Azure user tags implementation CFE-757: Update changes made during Azure user tags implementation Jan 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2023

@bharath-b-rh: This pull request references CFE-757 which is a valid jira issue.

Details

In response to this:

Update enhancement proposal with the observations/changes made during the course of implementation.

  • DNS zones and records allows to add tags with keys having only letters, numbers, period, hyphen or underscore characters. And can end with only letters, numbers or an underscore.
  • Update the Infrastructure CRD content updated with more description for the new fields added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-b-rh bharath-b-rh marked this pull request as ready for review February 6, 2023 13:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2023
@bharath-b-rh
Copy link
Contributor Author

/cc @JoelSpeed

@openshift-ci openshift-ci bot requested a review from JoelSpeed February 8, 2023 15:22
@JoelSpeed
Copy link
Contributor

/lgtm
/approve

I appreciate you keeping the enhancements up to date, thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6f0ff69 into openshift:master Feb 9, 2023
@bharath-b-rh bharath-b-rh deleted the cfe-757 branch February 13, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants