Skip to content

Conversation

@dhellmann
Copy link
Contributor

The linter job for #1189 was overridden, so invalid markdown landed. This
fixes the markup to make the job work for other PRs.

/assign @sdodson
/cc @patrickdillon

The linter job for openshift#1189 was overridden, so invalid markdown landed. This
fixes the markup to make the job work for other PRs.

Signed-off-by: Doug Hellmann <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Nov 14, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2022
@sdodson
Copy link
Member

sdodson commented Nov 14, 2022

This didn't break linting on unrelated changes, correct?

@openshift-merge-robot openshift-merge-robot merged commit 48228d0 into openshift:master Nov 14, 2022
@dhellmann
Copy link
Contributor Author

This didn't break linting on unrelated changes, correct?

It did. The markdown linter runs on all files for each PR. We could improve that if someone has the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants