expand the CVO featureset annotation to include other FeatureSets #1227
Conversation
| If the value is not "TechPreviewNoUpgrade", the manifest is never created. | ||
| Add an annotation that can be set on CVO manifests called `release.openshift.io/feature-set` that can be set to a comma | ||
| delimited list that can contain any value from | ||
| [FeatureSet](https://github.com/openshift/api/blob/master/config/v1/types_feature.go#L28-L43) and "Default" in place of "". |
There was a problem hiding this comment.
nit: line references like #L28-L43 mixed with a floating ref like master are brittle. Can we use this instead? [edit: actually that rendering seems too old]
Or:
- https://github.com/openshift/api/blob/master/config/v1/types_feature.go for "float, and they can grep for
FeatureSet" - https://github.com/openshift/api/blob/0f86a223d4bce1c63d9adce1f229afb08305a23b/config/v1/types_feature.go#L28-L43 for "pin, and if they want to figure out where it is today, they can find the dev branch and grep"
| in the installer and other bootstrapping components. | ||
|
|
||
| Because the cluster cannot upgrade to 4.y+1 and because the TechPreviewNoUpgrade flag cannot be unset, there is no concern | ||
| about removing any manifests that were added for TechPreviewNoUpgrade. |
There was a problem hiding this comment.
Upgrade / Downgrade Strategy and Version Skew Strategy sections will also need an overhaul.
deads2k
force-pushed
the
expand-cvo-featureset
branch
from
6611751 to
d6c82f3
Compare
|
updated for comments. |
deads2k
force-pushed
the
expand-cvo-featureset
branch
from
d6c82f3 to
a3fcff8
Compare
deads2k
force-pushed
the
expand-cvo-featureset
branch
from
a3fcff8 to
b5ee103
Compare
deads2k
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@deads2k: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
expand the enhancement to include the details from openshift/cluster-version-operator#821
/assign @wking