Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Apr 19, 2022

Users are occasionally confused by the "blocked edges" wording, which is internal shorthand.

The fact that update recommendations are tracked as a directed graph (hence "edges") isn't all that relevant for most users, so talk about "updates" instead of "edges".

While we occasionally drop update recommendations to reduce the chances that users update into serious issues, from docs:

When an update recommendation is supported, it remains supported for the life of 4.10, even if the update recommendation is later dropped or made conditional.

Updating is still possible, we just don't think it's a good idea (unless maybe you're elbow deep in a support case, and a support tech decides to recommend an update based on context that is not available to the update service). So replace "blocked" with "not recommended", to convey the "still possible" aspect.

Also ask for some more specifics in the impact statement template, as we gear up to support conditional updates fff9d3c (#821). I haven't gone as far as "tell us what PromQL to use in our conditional recommendation", but I'm easing things in that direction.

wking added 2 commits April 19, 2022 22:09
Because he approved the original pull request creating the directory
[1].

[1]: openshift#821 (comment)
Catching up with 36e98de (template: update guidance for specifying
that no API approver is needed, 2022-04-10, openshift#1087).
@wking wking force-pushed the block-edge-to-remove-recommendation branch from af8037b to 9252596 Compare April 20, 2022 05:09
…endations"

Users are occasionally confused by the "blocked edges" wording, which
is internal shorthand.

The fact that update recommendations are tracked as a directed graph
(hence "edges") isn't all that relevant for most users, so talk about
"updates" instead of "edges".

While we occasionally drop update recommendations to reduce the
chances that users update into serious issues, from [1]:

  When an update recommendation is supported, it remains supported for
  the life of 4.10, even if the update recommendation is later dropped
  or made conditional.

Updating is still possible, we just don't think it's a good idea
(unless maybe you're elbow deep in a support case, and a support tech
decides to recommend an update based on context that is not available
to the update service).  So replace "blocked" with "not recommended",
to convey the "still possible" aspect.

Also ask for some more specifics in the impact statement template, as
we gear up to support conditional updates fff9d3c
(enhancements/update/targeted-update-edge-blocking: Propose a new
enhancement, 2020-08-07, openshift#821).

[1]: https://docs.openshift.com/container-platform/4.10/updating/understanding-upgrade-channels-release.html#upgrade-version-paths_understanding-upgrade-channels-releases
@wking wking force-pushed the block-edge-to-remove-recommendation branch from 9252596 to 18de135 Compare April 20, 2022 16:15
@sdodson
Copy link
Member

sdodson commented Apr 22, 2022

/lgtm
/override ci/prow/markdownlint
This amends an existing enhancement

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2022

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/markdownlint

Details

In response to this:

/lgtm
/override ci/prow/markdownlint
This amends an existing enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2022

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@sdodson
Copy link
Member

sdodson commented Apr 22, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit bdf15e7 into openshift:master Apr 22, 2022
@wking wking deleted the block-edge-to-remove-recommendation branch April 23, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants