Skip to content

update package for 4.3#191

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
richm:update-package-for-4.3
Oct 8, 2019
Merged

update package for 4.3#191
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
richm:update-package-for-4.3

Conversation

@richm
Copy link
Contributor

@richm richm commented Oct 8, 2019

Need to update the package for 4.3. This is causing the oal ci failure
openshift/origin-aggregated-logging#1765
https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_origin-aggregated-logging/1765/pull-ci-openshift-origin-aggregated-logging-master-full-integ-aws/1497/build-log.txt

+++ curl -sOLJ https://raw.githubusercontent.com/openshift/elasticsearch-operator/master/manifests/elasticsearch-operator.package.yaml
...
https://github.com/openshift/origin-aggregated-logging/blob/master/hack/vendor/olm-test-script/e2e-olm.sh#L99
CURRENT_CSV=$(sed -nr 's,.*currentCSV: (.*),\1,p' $MANIFEST_DIR/*package.yaml)

so the version is in the package.yaml as well as elsewhere.

This will also need a similar change in the clo

@richm richm requested review from bparees and jcantrill October 8, 2019 19:38
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2019
@richm richm requested a review from ewolinetz October 8, 2019 19:39
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@richm
Copy link
Contributor Author

richm commented Oct 8, 2019

@bparees
Copy link
Contributor

bparees commented Oct 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@richm
Copy link
Contributor Author

richm commented Oct 8, 2019

have no idea why this failed - our error reporting is abysmal - no es pod logs, no eso pod logs

@openshift-merge-robot openshift-merge-robot merged commit 8220b51 into openshift:master Oct 8, 2019
@richm richm deleted the update-package-for-4.3 branch October 8, 2019 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants