Skip to content

Comments

UPSTREAM: docker/distribution: 3403: add application-credential auth support for swift storage driver #25

Merged
openshift-merge-robot merged 1 commit intoopenshift:image-registry-4.7-distribution-2461543from
bverschueren:support-swift-application-credentials-openshift
Sep 13, 2021
Merged

UPSTREAM: docker/distribution: 3403: add application-credential auth support for swift storage driver #25
openshift-merge-robot merged 1 commit intoopenshift:image-registry-4.7-distribution-2461543from
bverschueren:support-swift-application-credentials-openshift

Conversation

@bverschueren
Copy link

This add the ability to authenticate the Swift storage driver using keystone application credentials (by id/name).

Signed-off-by: Bram Verschueren <verschueren.bram@gmail.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bverschueren
To complete the pull request process, please assign bparees after the PR has been reviewed.
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bverschueren
Copy link
Author

@dmage @adambkaplan any thoughts ?

@dmage
Copy link

dmage commented May 4, 2021

@bverschueren do have a Jira issue for that?

@bverschueren
Copy link
Author

There is https://issues.redhat.com/browse/OSASINFRA-1934 which is related.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2021
@bverschueren
Copy link
Author

/remove-lifecycle stale
/lifecycle frozen

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2021

@bverschueren: The lifecycle/frozen label cannot be applied to Pull Requests.

Details

In response to this:

/remove-lifecycle stale
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link

dmage commented Sep 13, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bverschueren, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit e6425e8 into openshift:image-registry-4.7-distribution-2461543 Sep 13, 2021
@dmage
Copy link

dmage commented Sep 13, 2021

@bverschueren please bump docker-distribution in image-registry

@bverschueren bverschueren deleted the support-swift-application-credentials-openshift branch September 15, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants