NO-JIRA: Follow-ups for #275 #292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are taken from the existing openstack-cinder-csi-driver-operator like so: openstack-cinder-csi-driver-operator csi-operator ==================================== ============================================================== assets/csidriver.yaml assets/overlays/openstack-cinder/base/csidriver.yaml assets/storageclass.yaml assets/overlays/openstack-cinder/base/storageclass.yaml assets/volumesnapshotclass.yaml assets/overlays/openstack-cinder/base/volumesnapshotclass.yaml Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This file will be combined with 'assets/base/controller.yaml' to yield something that looks like 'assets/controller.yaml' [1] from openstack-cinder-csi-driver-operator. [1] https://github.com/openshift/openstack-cinder-csi-driver-operator/blob/release-4.17/assets/controller.yaml Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This file will be combined with 'assets/base/node.yaml' to yield something that looks like 'assets/node.yaml' [1] from openstack-cinder-csi-driver-operator. [1] https://github.com/openshift/openstack-cinder-csi-driver-operator/blob/release-4.17/assets/node.yaml Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The controller currently uses host networking, meaning it needs the privileged role. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This file will be combined with 'assets/common/sidecars/provisioner.yaml' to yield something that looks like the 'csi-provisioner' sidecar container definition in 'assets/controller.yaml' [1] from openstack-cinder-csi-driver-operator. [1] https://github.com/openshift/openstack-cinder-csi-driver-operator/blob/release-4.17/assets/controller.yaml Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We intentionally do not merge in our Cinder-specific (read: non-library-go-derived) controllers yet, seeking instead to keep this change as simple as possible. Most of the other controllers are already used in one form or another for other drivers. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This is simply: mkdir pkg/openstack-cinder cp -r legacy/openstack-cinder-csi-driver-operator/pkg/controllers/config pkg/openstack-cinder/config cp -r legacy/openstack-cinder-csi-driver-operator/pkg/util pkg/openstack-cinder/util ...followed by updating imports in the copied files along with amending 'go.mod' to add gophercloud and gophercloud/utils. Nothing uses this yet since we need to do some more minor surgery first which is kept separate to yield a readable diff. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Allow us to run this via the new shiny. The changes needed are surprisingly small. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
The important change here is to 'cmd/generator'. The rest of the change was auto-generated (surprise!) using 'make update'. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Now that we have a "native" Cinder CSI Operator here, we can start using it. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
We will add a quick start guide eventually but there's some more work to do first. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Trivial nit. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This won't appear in the generated assets, but that's okay: this is most relevant to OpenShift devs. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@stephenfin: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
@stephenfin: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
We're going to do this via #275 after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups addressing comments on #275. This should not merge before #275 does.