Skip to content

Comments

STOR-1713: Add Dockerfile.openshift symlink to Azure Disk#112

Closed
jsafrane wants to merge 1 commit intoopenshift:masterfrom
jsafrane:add-azure-disk-symlink
Closed

STOR-1713: Add Dockerfile.openshift symlink to Azure Disk#112
jsafrane wants to merge 1 commit intoopenshift:masterfrom
jsafrane:add-azure-disk-symlink

Conversation

@jsafrane
Copy link
Contributor

This is a temporary hack to fix CI builds.

CI syncs Dockerfile names from ART. ART metadata still has openshift/azure-disk-csi-driver-operator/Dockerfile.openshift as the Dockerfile. So create Dockerfile.openshift symlink, so CI can find openshift/csi-operator/Dockerfile.openshift and build Azure Disk from there temporarily, until ART medata is fixed.

This link must be removed after openshift-eng/ocp-build-data#4148 merges and CI starts using Dockerfile.azure-disk.

This is a temporary hack to fix CI builds.

CI syncs Dockerfile names from ART. ART metadata still has
openshift/azure-disk-csi-driver-operator/Dockerfile.openshift as the
Dockerfile. So create Dockerfile.openshift symlink, so CI can find
openshift/csi-operator/Dockerfile.openshift and build Azure Disk from there
temporarily, until ART medata is fixed.
@jsafrane jsafrane changed the title Add Dockerfile.openshift symlink to Azure Disk STOR-1713: Add Dockerfile.openshift symlink to Azure Disk Jan 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2024

@jsafrane: This pull request references STOR-1713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This is a temporary hack to fix CI builds.

CI syncs Dockerfile names from ART. ART metadata still has openshift/azure-disk-csi-driver-operator/Dockerfile.openshift as the Dockerfile. So create Dockerfile.openshift symlink, so CI can find openshift/csi-operator/Dockerfile.openshift and build Azure Disk from there temporarily, until ART medata is fixed.

This link must be removed after openshift-eng/ocp-build-data#4148 merges and CI starts using Dockerfile.azure-disk.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and gnufied January 11, 2024 10:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi-extended 8cacfd8 link false /test e2e-aws-csi-extended
ci/prow/e2e-azure-csi-extended 8cacfd8 link false /test e2e-azure-csi-extended
ci/prow/e2e-azurestack-csi 8cacfd8 link false /test e2e-azurestack-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor Author

/close
ART PR has merged

@openshift-ci openshift-ci bot closed this Jan 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

@jsafrane: Closed this PR.

Details

In response to this:

/close
ART PR has merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants