UPSTREAM: 502: Bug 1949018: Correct snapshotContent error propagation #48

huffmanca · 2021-04-29T16:14:39Z

What type of PR is this?
/kind bug

What this PR does / why we need it:
Currently if we fail to create a snapshot in a CSIFinalError way, the error is overwritten when we attempt to remove the annotation on the content. This can result in the snapshot controller logging the error, but subsequent logs (and events) being nil:

I0420 18:59:30.106430 1 snapshot_controller.go:301] createSnapshotWrapper: CreateSnapshot for content snapcontent-5e494f19-ea35-480c-89f8-626e6ad1dbd3 returned error: rpc error: code = Unknown desc = AzureDisk - invalid option invalid in VolumeSnapshotClass
...
E0420 18:59:30.506775 1 snapshot_controller.go:105] createSnapshot for content [snapcontent-5e494f19-ea35-480c-89f8-626e6ad1dbd3]: error occurred in createSnapshotWrapper: failed to take snapshot of the volume, ...%!q()

We don't see any Events with the correct error logged. By changing the error we're able to get the events correctly created. There are still periodic issues with stale resources, but these are addressed by changing to Patch (or by performing a Get in updateContentErrorStatusWithEvent). These changes are being made in kubernetes-csi#480 , and therefore I didn't include them here.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

VolumeSnapshotContent creation errors can now propagate to the appropriate VolumeSnapshotContent resource.

openshift-ci-robot · 2021-04-29T16:14:43Z

@huffmanca: This pull request references Bugzilla bug 1949018, which is invalid:

expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

UPSTREAM: 502: Bug 1949018: Correct snapshotContent error propagation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

huffmanca · 2021-04-29T16:15:11Z

/bugzilla refresh

openshift-ci-robot · 2021-04-29T16:15:18Z

@huffmanca: This pull request references Bugzilla bug 1949018, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsafrane · 2021-05-04T09:17:39Z

/lgtm

openshift-ci-robot · 2021-05-04T09:17:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [huffmanca,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-05-04T09:47:01Z

/retest