Skip to content

OCPBUGS-46727: CVE-2024-45338: bump golang.org/x/net to v0.34.0 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Feb 19, 2025
Merged

OCPBUGS-46727: CVE-2024-45338: bump golang.org/x/net to v0.34.0 #109

openshift-merge-bot merged 1 commit into from
Feb 19, 2025

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Jan 7, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@dobsonj: This pull request references Jira Issue OCPBUGS-46727, which is invalid:

  • expected the vulnerability to target either version "4.19." or "openshift-4.19.", but it targets "4.18.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 7, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 7, 2025

@dobsonj: This pull request references Jira Issue OCPBUGS-46727, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-46727

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 7, 2025
@dobsonj
Copy link
Member Author

dobsonj commented Jan 7, 2025

/hold for upstream

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@dobsonj dobsonj force-pushed the OCPBUGS-46727-origin-master branch from 14453ae to 784dc1e Compare January 7, 2025 23:18
@dobsonj dobsonj marked this pull request as ready for review January 7, 2025 23:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 7, 2025
@openshift-ci openshift-ci bot requested review from RomanBednar and jsafrane January 7, 2025 23:19
@dobsonj dobsonj force-pushed the OCPBUGS-46727-origin-master branch from 784dc1e to 7a90894 Compare January 13, 2025 18:52
@dobsonj dobsonj changed the title OCPBUGS-46727: CVE-2024-45338: bump golang.org/x/net to v0.33.0 OCPBUGS-46727: CVE-2024-45338: bump golang.org/x/net to v0.34.0 Jan 13, 2025
@dobsonj
Copy link
Member Author

dobsonj commented Jan 13, 2025

/unhold
This merged in a different PR to bump x/net to 0.34.0. Updated commit.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2025
@jsafrane
Copy link

jsafrane commented Jan 15, 2025

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2025 •
edited
Loading

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 7a90894 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@duanwei33
Copy link

duanwei33 commented Feb 11, 2025

/retest-required

@duanwei33
Copy link

duanwei33 commented Feb 11, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2025

@dobsonj: This pull request references Jira Issue OCPBUGS-46727, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-46727

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tsmetana
Copy link
Member

tsmetana commented Feb 19, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7e8d9a0 into openshift:master Feb 19, 2025
10 of 11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2025

@dobsonj: Jira Issue OCPBUGS-46727: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-46727 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-46727

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

openshift-bot commented Feb 20, 2025

[ART PR BUILD NOTIFIER]

Distgit: csi-provisioner
This PR has been included in build csi-provisioner-container-v4.19.0-202502192300.p0.g7e8d9a0.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@RomanBednar RomanBednar Awaiting requested review from RomanBednar

Assignees

@jsafrane jsafrane

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dobsonj @openshift-ci-robot @jsafrane @duanwei33 @tsmetana @openshift-bot