Skip to content

UPSTREAM: 379: Fix gofmt for go 1.19#47

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.12from
jsafrane:4.12-go-1.19
Nov 3, 2022
Merged

UPSTREAM: 379: Fix gofmt for go 1.19#47
openshift-merge-robot merged 2 commits intoopenshift:release-4.12from
jsafrane:4.12-go-1.19

Conversation

@jsafrane
Copy link

@jsafrane jsafrane commented Nov 3, 2022

Fix gofmt issue from kubernetes-csi#379 + updating csi-attacher images to be consistent with ART.

@openshift/storage

bertinatto and others added 2 commits November 3, 2022 10:28
gofmt 1.19 requires an empty line before `package`, otherwise it reformats
the license header.
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

UPSTREAM: 379: Fix gofmt for go 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from bertinatto and tsmetana November 3, 2022 09:31
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@jsafrane
Copy link
Author

jsafrane commented Nov 3, 2022

Copying labels from #46

@jsafrane jsafrane added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Nov 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6945eef into openshift:release-4.12 Nov 3, 2022
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build csi-attacher-container-v4.12.0-202305022015.p0.g6945eef.assembly.stream for distgit csi-attacher.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants