Skip to content

Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 13 commits into from
Apr 7, 2022
Merged

Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master #80

openshift-merge-robot merged 13 commits into from
Apr 7, 2022

Conversation

@shiftstack-merge-bot
Copy link

@shiftstack-merge-bot shiftstack-merge-bot bot commented Apr 4, 2022

No description provided.

@openshift-ci openshift-ci bot requested review from MaysaMacedo and mdbooth April 4, 2022 12:06
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 4, 2022

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx
Merge pull request kubernetes-csi#306 from andyzhangx/refine-pv-doc
39ece50 
doc: refine PV doc
@andyzhangx
test: fix golint error
6890b3d 
test: test with golinter v1.44

fix

fix

fix

use reviewdog/action-golangci-lint

test: run golint on 1.17

fix
@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 4, 2022

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2022
@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 4, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2022

@shiftstack-merge-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreprinetti
Copy link
Member

pierreprinetti commented Apr 7, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierreprinetti, shiftstack-merge-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 78df949 into openshift:master Apr 7, 2022
@pierreprinetti pierreprinetti deleted the merge-bot-master branch April 7, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaysaMacedo MaysaMacedo Awaiting requested review from MaysaMacedo

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@pierreprinetti pierreprinetti

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pierreprinetti @openshift-merge-robot @andyzhangx @pohly @k8s-ci-robot