Windows go version #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, the Go version for the Windows tests in Github actions was set as `1.16.x`, which mysteriously resolved to `1.15.15`[1]. With this patch, the Go version for the Windows tests is set as a semver range. This patch also bumps `actions/setup-go`[2] to the latest version, consistent with the other platforms. [1]: https://github.com/kubernetes-csi/csi-driver-nfs/runs/4211323920?check_suite_focus=true [2]: https://github.com/actions/setup-go
In order to rapidly debug test issues, issue `go version` prior to running any test.
Member
Author
|
/close |
openshift-ci
bot
added
the
kind/failing-test
|
@pierreprinetti: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind failing-test
What this PR does / why we need it:
Prior to this patch, the Go version for the Windows tests in Github
actions was set as
1.16.x, which mysteriously resolved to1.15.15.With this patch, the Go version for the Windows tests is set as a semver
range.
This patch also bumps
actions/setup-go2 to the latest version,consistent with the other platforms.
Lastly, in order to rapidly debug test issues, issue
go versionprior torunning any test.
Does this PR introduce a user-facing change?: