Skip to content

Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Nov 4, 2021
Merged

Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into master #57

openshift-merge-robot merged 3 commits into from
Nov 4, 2021

Conversation

@shiftstack-merge-bot
Copy link

@shiftstack-merge-bot shiftstack-merge-bot bot commented Nov 4, 2021

No description provided.

groggemans and others added 3 commits November 1, 2021 13:21
@groggemans
Fix armv7 docker builds
741a706 
Moves the ARCH build argument after the first FROM so it has the proper
value. Default value is empty as required by release-tools/build.make.
(https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact)

Adds the GOARM=7 option to the armv7 GO build.
@k8s-ci-robot
Merge pull request kubernetes-csi#240 from groggemans/fix/kubernetes-…
96d13a5 
…csiGH-239

fix: armv7 docker builds
Merge https://github.com/kubernetes-csi/csi-driver-nfs:master into ma…
95bea9c 
…ster
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2021
@EmilienM
Copy link
Member

EmilienM commented Nov 4, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2021
@EmilienM
Copy link
Member

EmilienM commented Nov 4, 2021

/lgtm
/approve
/hold

Sounds like a minor change, but let's wait on CI to see.
Please hold cancel if I don't get back to it soon.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021
@EmilienM
Copy link
Member

EmilienM commented Nov 4, 2021

/hold cancel
CI green, ship it

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021
@EmilienM
Copy link
Member

EmilienM commented Nov 4, 2021

/approve

1 similar comment
@EmilienM
Copy link
Member

EmilienM commented Nov 4, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, shiftstack-merge-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit c5dfd13 into openshift:master Nov 4, 2021
@pierreprinetti pierreprinetti deleted the merge-bot-master branch November 9, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamemilio iamemilio Awaiting requested review from iamemilio

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

Assignees

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EmilienM @openshift-merge-robot @groggemans @k8s-ci-robot