Skip to content

Bug 1880103: Bump deps for Kube 1.19 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 5 commits into from
Sep 22, 2020
Merged

Bug 1880103: Bump deps for Kube 1.19 #42

openshift-merge-robot merged 5 commits into from
Sep 22, 2020

Conversation

@sgreene570
Copy link

@sgreene570 sgreene570 commented Sep 17, 2020

This PR bumps the kube specific dependencies in openshift/coredns to kube 1.19.

The following upstream PRs were (paritally) cherry-picked to accommodate this.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 17, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 17, 2020

@sgreene570: This pull request references Bugzilla bug 1880103, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1880103: Bump deps for Kube 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 17, 2020
@sgreene570
Copy link
Author

sgreene570 commented Sep 17, 2020

Unit test failures are go1.12 specific.
Depends on #41
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 19, 2020
Merged
@sgreene570
Copy link
Author

sgreene570 commented Sep 21, 2020

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020
@sgreene570
Copy link
Author

sgreene570 commented Sep 21, 2020

needs openshift/release#12084

Miciah
Miciah requested changes Sep 21, 2020
View reviewed changes
core/plugin/zplugin.go Outdated
Copy link

@Miciah Miciah Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep coredns-mdns for KNI (bare metal).

Copy link
Author

@sgreene570 sgreene570 Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Pushing a fix. Thanks!

Copy link
Author

@sgreene570 sgreene570 Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Note to self: Triple check upstream commit contents before cherry-picking)

Copy link
Author

@sgreene570 sgreene570 Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 😁

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 21, 2020
Merged
@sgreene570 sgreene570 force-pushed the kube-1.19-bump branch 2 times, most recently from 8642f93 to 5af7671 Compare September 21, 2020 19:26
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2020
@sgreene570
Copy link
Author

sgreene570 commented Sep 21, 2020

/retest

@bcrochet
Copy link
Member

bcrochet commented Sep 21, 2020

/test e2e-metal-ipi

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 21, 2020

@bcrochet: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-upgrade
  • /test images
  • /test unit

Use /test all to run all jobs.

Details

In response to this:

/test e2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 21, 2020
Merged
@sgreene570
Copy link
Author

sgreene570 commented Sep 21, 2020

/test e2e-aws

@cybertron
Copy link
Member

cybertron commented Sep 21, 2020

We need openshift/release#9770 to have the metal ci job on this repo. I don't expect problems from this change, but we should test it to be sure.

@sgreene570
Copy link
Author

sgreene570 commented Sep 22, 2020

/test e2e-metal-ipi

@sgreene570
Copy link
Author

sgreene570 commented Sep 22, 2020

/retest

@sgreene570
Copy link
Author

sgreene570 commented Sep 22, 2020

@cybertron looks like the metal-ipi job passed. Thanks for the input!

@Miciah
Copy link

Miciah commented Sep 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 546f3f0 into openshift:master Sep 22, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2020

@sgreene570: All pull requests linked via external trackers have merged:

Bugzilla bug 1880103 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1880103: Bump deps for Kube 1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bentito pushed a commit to bentito/coredns that referenced this pull request Nov 21, 2025
@openshift-merge-robot
Merge pull request openshift#42 from sgreene570/kube-1.19-bump
2376481 
Bug 1880103: Bump deps for Kube 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Miciah Miciah Miciah requested changes

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@Miciah Miciah

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sgreene570 @openshift-ci-robot @bcrochet @cybertron @Miciah @openshift-merge-robot