Add github.com/openshift/coredns-mdns plugin #14

celebdor · 2019-06-20T11:22:54Z

Signed-off-by: Antoni Segura Puimedon antoni@redhat.com

1. Why is this pull request needed and what does it do?

This PR adds the coredns-mdns plugin developed to allow coredns to be used in environments without resolution for openshift nodes thanks to its interaction with github.com/openshfit/mdns-publisher.

This should not affect cluster dns operation as the plugin won't be loaded by the cluster-dns-operator Corefile.

celebdor · 2019-06-20T11:24:50Z

At the moment the gopkg.toml points to the openshift branch. When we get the results of the CI we'll merge the patch to github.com/openshift/coredns-mdns and update the dep here.

cybertron

Tested locally, works for me.

knobunc · 2019-06-28T18:25:53Z

/lgtm

ironcladlou · 2019-06-28T18:36:27Z

Will this configuration ever be merged upstream? Is there a comparative approach which allows enabling the plugin without carrying a patch to CoreDNS? (This makes me wonder if we should be building and shipping a wrapper entry point to enable use of external plugins — it might even obviate the need for a custom image build of CoreDNS since we would be vendoring...)

cybertron · 2019-06-28T19:22:29Z

Your link discusses the two options I'm aware of for enabling external plugins. Both of them require code changes, either here or in the wrapper. The only way I can see to avoid carrying a patch would be to make this a whole new image and do the patching at image build time, which seems like overkill to me.

We have talked about trying to get the mdns plugin upstream, but it's not likely to happen in time for 4.2, which is where we're going to start needing it.

ironcladlou · 2019-07-03T16:58:24Z

Okay, after much discussion, we've decided to try and catch master up with upstream and then rebase this PR to use Go modules and merge it. Thanks for bearing with us!

This plugin allows for discovering hosts via mDNS browsing, which means that those nodes are then exposed via normal unicast DNS.

The baremetal platform (IPI for Bare Metal hosts) includes some additional assets on the bootstrap node for automating some infrastructure requirements that would have normally been handled by some cloud infrastructure service. See data/data/bootstrap/baremetal/README.md for more detailed documentation. Co-authored-by: Ben Nemec <bnemec@redhat.com> Co-authored-by: Mark McLoughlin <markmc@redhat.com> Co-authored-by: Russell Bryant <rbryant@redhat.com> Co-authored-by: Stephen Benjamin <stephen@redhat.com> Co-authored-by: Steven Hardy <shardy@redhat.com>

knobunc · 2019-07-10T14:46:10Z

/retest

celebdor · 2019-07-10T14:48:40Z

Passed the tests locally:

** presubmit/filename-hyphen
** presubmit/import-testing
** presubmit/test-lowercase
** presubmit/trailing-whitespace
( cd request ; go test -v -race ./... )
=== RUN   TestRequestDo
--- PASS: TestRequestDo (0.00s)
=== RUN   TestRequestRemote
--- PASS: TestRequestRemote (0.00s)
=== RUN   TestRequestMalformed
--- PASS: TestRequestMalformed (0.00s)
=== RUN   TestRequestScrubAnswer
--- PASS: TestRequestScrubAnswer (0.01s)
=== RUN   TestRequestScrubExtra
--- PASS: TestRequestScrubExtra (0.01s)
=== RUN   TestRequestScrubExtraEdns0
--- PASS: TestRequestScrubExtraEdns0 (0.01s)
=== RUN   TestRequestScrubExtraRegression
--- PASS: TestRequestScrubExtraRegression (0.00s)
=== RUN   TestTruncation
--- PASS: TestTruncation (0.80s)
=== RUN   TestRequestScrubAnswerExact
--- PASS: TestRequestScrubAnswerExact (0.00s)
=== RUN   TestRequestMatch
--- PASS: TestRequestMatch (0.00s)
=== RUN   TestRequestClear
--- PASS: TestRequestClear (0.00s)
PASS
ok  	github.com/coredns/coredns/request	(cached)
( cd core ; go test -v -race  ./... )
?   	github.com/coredns/coredns/core	[no test files]
=== RUN   TestNormalizeZone
--- PASS: TestNormalizeZone (0.00s)
=== RUN   TestNormalizeZoneReverse
--- PASS: TestNormalizeZoneReverse (0.00s)
=== RUN   TestSplitProtocolHostPort
--- PASS: TestSplitProtocolHostPort (0.00s)
=== RUN   TestOverlapAddressChecker
--- PASS: TestOverlapAddressChecker (0.00s)
=== RUN   TestHandler
--- PASS: TestHandler (0.00s)
=== RUN   TestHandlers
--- PASS: TestHandlers (0.00s)
=== RUN   TestGroupingServers
--- PASS: TestGroupingServers (0.00s)
=== RUN   TestNewServer
--- PASS: TestNewServer (0.00s)
PASS
ok  	github.com/coredns/coredns/core/dnsserver	(cached)
?   	github.com/coredns/coredns/core/plugin	[no test files]
( cd coremain ; go test -v -race ./... )
=== RUN   TestSetCPU
--- PASS: TestSetCPU (0.00s)
PASS
ok  	github.com/coredns/coredns/coremain	(cached)
( cd test ; go test -v -race ./... )
=== RUN   TestAuto
=== PAUSE TestAuto
=== RUN   TestAutoNonExistentZone
=== PAUSE TestAutoNonExistentZone
=== RUN   TestAutoAXFR
=== PAUSE TestAutoAXFR
=== RUN   TestLookupCache
=== RUN   TestLookupCache/Long_TTL
=== RUN   TestLookupCache/Short_TTL
--- PASS: TestLookupCache (0.01s)
    --- PASS: TestLookupCache/Long_TTL (0.00s)
    --- PASS: TestLookupCache/Short_TTL (0.00s)
=== RUN   TestChaos
--- PASS: TestChaos (0.00s)
=== RUN   TestCompressScrub
--- PASS: TestCompressScrub (0.00s)
=== RUN   TestLookupDS
=== PAUSE TestLookupDS
=== RUN   TestEDNS0
--- PASS: TestEDNS0 (0.00s)
=== RUN   TestLookupAutoPathErratic
--- PASS: TestLookupAutoPathErratic (0.01s)
=== RUN   TestAutoPathErraticNotLoaded
--- PASS: TestAutoPathErraticNotLoaded (0.00s)
=== RUN   TestZoneExternalCNAMELookupWithoutProxy
=== PAUSE TestZoneExternalCNAMELookupWithoutProxy
=== RUN   TestZoneExternalCNAMELookupWithProxy
=== PAUSE TestZoneExternalCNAMELookupWithProxy
=== RUN   TestZoneReload
--- PASS: TestZoneReload (2.00s)
=== RUN   TestZoneEDNS0Lookup
=== PAUSE TestZoneEDNS0Lookup
=== RUN   TestZoneNoNS
=== PAUSE TestZoneNoNS
=== RUN   TestZoneSRVAdditional
=== PAUSE TestZoneSRVAdditional
=== RUN   TestTempFile
=== PAUSE TestTempFile
=== RUN   TestFileUpstream
--- PASS: TestFileUpstream (0.01s)
=== RUN   TestFileUpstreamAdditional
--- PASS: TestFileUpstreamAdditional (0.01s)
=== RUN   TestLargeAXFR
--- PASS: TestLargeAXFR (4.19s)
=== RUN   TestGrpc
--- PASS: TestGrpc (0.00s)
=== RUN   TestHostsInlineLookup
--- PASS: TestHostsInlineLookup (0.00s)
=== RUN   TestMetricsServer
--- PASS: TestMetricsServer (0.01s)
=== RUN   TestMetricsRefused
--- PASS: TestMetricsRefused (0.03s)
=== RUN   TestMetricsAuto
--- PASS: TestMetricsAuto (2.29s)
=== RUN   TestMetricsSeveralBlocs
--- PASS: TestMetricsSeveralBlocs (0.15s)
=== RUN   TestMetricsPluginEnabled
--- PASS: TestMetricsPluginEnabled (0.04s)
=== RUN   TestLookupBalanceRewriteCacheDnssec
=== PAUSE TestLookupBalanceRewriteCacheDnssec
=== RUN   TestProxyThreeWay
--- PASS: TestProxyThreeWay (6.03s)
=== RUN   TestLookupProxy
=== PAUSE TestLookupProxy
=== RUN   TestReadme
--- PASS: TestReadme (0.11s)
=== RUN   TestReload
--- PASS: TestReload (0.00s)
=== RUN   TestReloadHealth
--- PASS: TestReloadHealth (0.00s)
=== RUN   TestReloadMetricsHealth
--- PASS: TestReloadMetricsHealth (1.05s)
=== RUN   TestReloadSeveralTimeMetrics
--- PASS: TestReloadSeveralTimeMetrics (0.10s)
=== RUN   TestMetricsAvailableAfterReload
--- PASS: TestMetricsAvailableAfterReload (0.13s)
=== RUN   TestMetricsAvailableAfterReloadAndFailedReload
--- PASS: TestMetricsAvailableAfterReloadAndFailedReload (0.12s)
=== RUN   TestReverseCorefile
--- PASS: TestReverseCorefile (0.00s)
=== RUN   TestRewrite
=== PAUSE TestRewrite
=== RUN   TestEmptySecondaryZone
--- PASS: TestEmptySecondaryZone (0.00s)
=== RUN   TestSecondaryZoneTransfer
--- PASS: TestSecondaryZoneTransfer (0.01s)
=== RUN   TestClasslessReverse
--- PASS: TestClasslessReverse (0.00s)
=== RUN   TestReverse
--- PASS: TestReverse (0.00s)
=== RUN   TestReverseInAddr
--- PASS: TestReverseInAddr (0.00s)
=== RUN   TestProxyToChaosServer
=== PAUSE TestProxyToChaosServer
=== RUN   TestTemplateUpstream
--- PASS: TestTemplateUpstream (0.00s)
=== RUN   TestLookupWildcard
=== PAUSE TestLookupWildcard
=== CONT  TestAuto
=== CONT  TestZoneSRVAdditional
=== CONT  TestLookupDS
=== CONT  TestZoneEDNS0Lookup
--- PASS: TestZoneSRVAdditional (0.01s)
=== CONT  TestZoneNoNS
--- PASS: TestLookupDS (0.01s)
=== CONT  TestZoneExternalCNAMELookupWithProxy
=== CONT  TestAutoNonExistentZone
--- PASS: TestZoneEDNS0Lookup (0.01s)
--- PASS: TestZoneNoNS (0.01s)
=== CONT  TestZoneExternalCNAMELookupWithoutProxy
--- PASS: TestAutoNonExistentZone (0.00s)
=== CONT  TestAutoAXFR
--- PASS: TestZoneExternalCNAMELookupWithoutProxy (0.00s)
=== CONT  TestProxyToChaosServer
=== CONT  TestLookupWildcard
--- PASS: TestProxyToChaosServer (0.00s)
=== CONT  TestTempFile
--- PASS: TestLookupWildcard (0.00s)
=== CONT  TestLookupBalanceRewriteCacheDnssec
--- PASS: TestTempFile (0.00s)
--- PASS: TestLookupBalanceRewriteCacheDnssec (0.01s)
=== CONT  TestLookupProxy
=== CONT  TestRewrite
--- PASS: TestLookupProxy (0.00s)
--- PASS: TestRewrite (0.00s)
--- PASS: TestZoneExternalCNAMELookupWithProxy (0.04s)
--- PASS: TestAutoAXFR (1.11s)
--- PASS: TestAuto (2.61s)
PASS
ok  	github.com/coredns/coredns/test	20.028s
( cd plugin ; go test -v -race ./... )
=== RUN   TestZoneMatches
--- PASS: TestZoneMatches (0.00s)
=== RUN   TestZoneNormalize
--- PASS: TestZoneNormalize (0.00s)
=== RUN   TestNameMatches
--- PASS: TestNameMatches (0.00s)
=== RUN   TestNameNormalize
--- PASS: TestNameNormalize (0.00s)
=== RUN   TestHostNormalize
--- PASS: TestHostNormalize (0.00s)
=== RUN   TestSplitHostPortReverse
--- PASS: TestSplitHostPortReverse (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin	(cached)
=== RUN   TestAny
--- PASS: TestAny (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/any	(cached)
=== RUN   TestRewriteToExpand
--- PASS: TestRewriteToExpand (0.00s)
=== RUN   TestAutoParse
--- PASS: TestAutoParse (0.00s)
=== RUN   TestWalk
--- PASS: TestWalk (0.00s)
=== RUN   TestWalkNonExistent
--- PASS: TestWalkNonExistent (0.00s)
=== RUN   TestWatcher
--- PASS: TestWatcher (0.00s)
=== RUN   TestSymlinks
--- PASS: TestSymlinks (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/auto	(cached)
=== RUN   TestAutoPath
--- PASS: TestAutoPath (0.00s)
=== RUN   TestAutoPathNoAnswer
--- PASS: TestAutoPathNoAnswer (0.00s)
=== RUN   TestInSearchPath
--- PASS: TestInSearchPath (0.00s)
=== RUN   TestSetupAutoPath
--- PASS: TestSetupAutoPath (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/autopath	(cached)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/bind	(cached)
=== RUN   TestCache
--- PASS: TestCache (0.00s)
=== RUN   TestCacheZeroTTL
--- PASS: TestCacheZeroTTL (0.00s)
=== RUN   TestComputeTTL
--- PASS: TestComputeTTL (0.00s)
=== RUN   TestFormErr
--- PASS: TestFormErr (0.00s)
=== RUN   TestPrefetch
=== RUN   TestPrefetch/hits.reset.example.org.
=== RUN   TestPrefetch/short.ttl.example.org.
=== RUN   TestPrefetch/no.prefetch.example.org.
--- PASS: TestPrefetch (0.01s)
    --- PASS: TestPrefetch/hits.reset.example.org. (0.00s)
    --- PASS: TestPrefetch/short.ttl.example.org. (0.00s)
    --- PASS: TestPrefetch/no.prefetch.example.org. (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.01s)
=== RUN   TestSpoof
--- PASS: TestSpoof (0.00s)
=== RUN   TestResponse
--- PASS: TestResponse (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/cache	(cached)
=== RUN   TestFreqUpdate
--- PASS: TestFreqUpdate (0.00s)
=== RUN   TestReset
--- PASS: TestReset (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/cache/freq	(cached)
=== RUN   TestCancel
--- PASS: TestCancel (0.02s)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/cancel	(cached)
=== RUN   TestChaos
--- PASS: TestChaos (0.00s)
=== RUN   TestSetupChaos
--- PASS: TestSetupChaos (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/chaos	(cached)
=== RUN   TestDebug
--- PASS: TestDebug (0.00s)
=== RUN   TestNoDebug
--- PASS: TestNoDebug (0.00s)
=== RUN   TestHexdump
--- PASS: TestHexdump (0.00s)
=== RUN   TestHexdumpf
--- PASS: TestHexdumpf (0.00s)
=== RUN   ExampleLogHexdump
--- PASS: ExampleLogHexdump (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/debug	(cached)
?   	github.com/coredns/coredns/plugin/deprecated	[no test files]
=== RUN   TestBlackLiesBitmapNoData
--- PASS: TestBlackLiesBitmapNoData (0.03s)
=== RUN   TestBlackLiesBitmapNameError
--- PASS: TestBlackLiesBitmapNameError (0.00s)
=== RUN   TestZoneSigningBlackLies
--- PASS: TestZoneSigningBlackLies (0.00s)
=== RUN   TestBlackLiesNoError
--- PASS: TestBlackLiesNoError (0.00s)
=== RUN   TestCacheSet
--- PASS: TestCacheSet (0.00s)
=== RUN   TestCacheNotValidExpired
--- PASS: TestCacheNotValidExpired (0.00s)
=== RUN   TestCacheNotValidYet
--- PASS: TestCacheNotValidYet (0.00s)
=== RUN   TestZoneSigning
--- PASS: TestZoneSigning (0.00s)
=== RUN   TestZoneSigningDouble
--- PASS: TestZoneSigningDouble (0.02s)
=== RUN   TestSigningDifferentZone
--- PASS: TestSigningDifferentZone (0.00s)
=== RUN   TestSigningCname
--- PASS: TestSigningCname (0.00s)
=== RUN   TestSigningDname
--- PASS: TestSigningDname (0.00s)
=== RUN   TestSigningEmpty
--- PASS: TestSigningEmpty (0.00s)
=== RUN   TestLookupZone
--- PASS: TestLookupZone (0.01s)
=== RUN   TestLookupDNSKEY
--- PASS: TestLookupDNSKEY (0.00s)
=== RUN   TestSetupDnssec
--- PASS: TestSetupDnssec (0.01s)
PASS
ok  	github.com/coredns/coredns/plugin/dnssec	(cached)
=== RUN   TestDnstapContext
--- PASS: TestDnstapContext (0.00s)
=== RUN   TestDnstap
--- PASS: TestDnstap (0.00s)
=== RUN   TestError
--- PASS: TestError (0.00s)
=== RUN   TestConfig
--- PASS: TestConfig (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/dnstap	(cached)
=== RUN   TestEncoderCompatibility
--- PASS: TestEncoderCompatibility (0.00s)
=== RUN   TestTransport
--- PASS: TestTransport (2.01s)
=== RUN   TestRace
--- PASS: TestRace (1.01s)
=== RUN   TestReconnect
--- PASS: TestReconnect (6.01s)
PASS
ok  	github.com/coredns/coredns/plugin/dnstap/dnstapio	(cached)
=== RUN   TestRequest
--- PASS: TestRequest (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/dnstap/msg	(cached)
=== RUN   TestClientQueryResponse
--- PASS: TestClientQueryResponse (0.00s)
=== RUN   TestClientQueryResponseWithSendOption
--- PASS: TestClientQueryResponseWithSendOption (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/dnstap/taprw	(cached)
?   	github.com/coredns/coredns/plugin/dnstap/test	[no test files]
=== RUN   TestErraticDrop
--- PASS: TestErraticDrop (0.00s)
=== RUN   TestErraticTruncate
--- PASS: TestErraticTruncate (0.00s)
=== RUN   TestAxfr
--- PASS: TestAxfr (0.00s)
=== RUN   TestErratic
--- PASS: TestErratic (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
=== RUN   TestParseErratic
--- PASS: TestParseErratic (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/erratic	(cached)
=== RUN   TestErrors
--- PASS: TestErrors (0.00s)
=== RUN   TestLogPattern
--- PASS: TestLogPattern (0.00s)
=== RUN   TestInc
--- PASS: TestInc (0.00s)
=== RUN   TestStop
--- PASS: TestStop (0.00s)
=== RUN   TestServeDNSConcurrent
--- PASS: TestServeDNSConcurrent (89.41s)
    errors_test.go:374: 14641 consolidated messages found
=== RUN   TestErrorsParse
--- PASS: TestErrorsParse (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/errors	(cached)
testing: warning: no tests to run
PASS
ok  	github.com/coredns/coredns/plugin/etcd	(cached) [no tests to run]
=== RUN   TestPath
--- PASS: TestPath (0.00s)
=== RUN   TestSplit255
--- PASS: TestSplit255 (0.00s)
=== RUN   TestGroup
--- PASS: TestGroup (0.00s)
=== RUN   TestType
--- PASS: TestType (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/etcd/msg	(cached)
=== RUN   TestIsNameFederation
--- PASS: TestIsNameFederation (0.00s)
=== RUN   TestFederationKubernetes
--- PASS: TestFederationKubernetes (0.00s)
=== RUN   TestFederationKubernetesMissingLabels
--- PASS: TestFederationKubernetesMissingLabels (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/federation	(cached)
=== RUN   TestClosestEncloser
--- PASS: TestClosestEncloser (0.00s)
=== RUN   TestLookupDelegation
--- PASS: TestLookupDelegation (0.00s)
=== RUN   TestLookupSecureDelegation
--- PASS: TestLookupSecureDelegation (0.00s)
=== RUN   TestLookupDNSSEC
--- PASS: TestLookupDNSSEC (0.01s)
=== RUN   TestLookupDS
--- PASS: TestLookupDS (0.00s)
=== RUN   TestLookupEnt
--- PASS: TestLookupEnt (0.00s)
=== RUN   TestParseNoSOA
--- PASS: TestParseNoSOA (0.00s)
=== RUN   TestLookupGlue
--- PASS: TestLookupGlue (0.01s)
=== RUN   TestInclude
--- PASS: TestInclude (0.00s)
=== RUN   TestLookup
--- PASS: TestLookup (0.00s)
=== RUN   TestLookupNil
--- PASS: TestLookupNil (0.00s)
=== RUN   TestParseNSEC3PARAM
--- PASS: TestParseNSEC3PARAM (0.00s)
=== RUN   TestParseNSEC3
--- PASS: TestParseNSEC3 (0.00s)
=== RUN   TestZoneReload
--- PASS: TestZoneReload (2.00s)
=== RUN   TestZoneReloadSOAChange
--- PASS: TestZoneReloadSOAChange (0.00s)
=== RUN   TestLess
--- PASS: TestLess (0.00s)
=== RUN   TestShouldTransfer
--- PASS: TestShouldTransfer (0.00s)
=== RUN   TestTransferIn
--- PASS: TestTransferIn (0.00s)
=== RUN   TestIsNotify
--- PASS: TestIsNotify (0.00s)
=== RUN   TestFileParse
--- PASS: TestFileParse (0.02s)
=== RUN   TestLookupWildcard
--- PASS: TestLookupWildcard (0.01s)
=== RUN   TestLookupDoubleWildcard
--- PASS: TestLookupDoubleWildcard (0.00s)
=== RUN   TestReplaceWithAsteriskLabel
--- PASS: TestReplaceWithAsteriskLabel (0.00s)
=== RUN   TestLookupApexWildcard
--- PASS: TestLookupApexWildcard (0.00s)
=== RUN   TestLookupMultiWildcard
--- PASS: TestLookupMultiWildcard (0.00s)
=== RUN   TestNameFromRight
--- PASS: TestNameFromRight (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/file	(cached)
=== RUN   TestLess
--- PASS: TestLess (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/file/tree	(cached)
=== RUN   TestDnstap
--- PASS: TestDnstap (0.00s)
=== RUN   TestNoDnstap
--- PASS: TestNoDnstap (0.00s)
=== RUN   TestHealth
--- PASS: TestHealth (1.00s)
=== RUN   TestHealthTimeout
--- PASS: TestHealthTimeout (3.00s)
=== RUN   TestHealthFailTwice
--- PASS: TestHealthFailTwice (5.00s)
=== RUN   TestHealthMaxFails
--- PASS: TestHealthMaxFails (9.00s)
=== RUN   TestHealthNoMaxFails
--- PASS: TestHealthNoMaxFails (7.00s)
=== RUN   TestCached
--- PASS: TestCached (0.00s)
=== RUN   TestCleanupByTimer
--- PASS: TestCleanupByTimer (0.25s)
=== RUN   TestPartialCleanup
--- PASS: TestPartialCleanup (0.13s)
=== RUN   TestCleanupAll
--- PASS: TestCleanupAll (0.00s)
=== RUN   TestProxyClose
--- PASS: TestProxyClose (0.38s)
=== RUN   TestProxy
--- PASS: TestProxy (0.00s)
=== RUN   TestProxyTLSFail
--- PASS: TestProxyTLSFail (6.01s)
=== RUN   TestProtocolSelection
--- PASS: TestProtocolSelection (0.00s)
=== RUN   TestSetupPolicy
--- PASS: TestSetupPolicy (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
=== RUN   TestSetupTLS
--- PASS: TestSetupTLS (0.00s)
=== RUN   TestSetupResolvconf
--- PASS: TestSetupResolvconf (2.00s)
PASS
ok  	github.com/coredns/coredns/plugin/forward	(cached)
=== RUN   TestGRPC
=== RUN   TestGRPC/single_proxy_ok
=== RUN   TestGRPC/multiple_proxies_ok
=== RUN   TestGRPC/single_proxy_ko
=== RUN   TestGRPC/multiple_proxies_one_ko
=== RUN   TestGRPC/multiple_proxies_ko
--- PASS: TestGRPC (0.00s)
    --- PASS: TestGRPC/single_proxy_ok (0.00s)
    --- PASS: TestGRPC/multiple_proxies_ok (0.00s)
    --- PASS: TestGRPC/single_proxy_ko (0.00s)
    --- PASS: TestGRPC/multiple_proxies_one_ko (0.00s)
    --- PASS: TestGRPC/multiple_proxies_ko (0.00s)
=== RUN   TestProxy
=== RUN   TestProxy/response_ok
=== RUN   TestProxy/nil_response
=== RUN   TestProxy/tls
--- PASS: TestProxy (0.00s)
    --- PASS: TestProxy/response_ok (0.00s)
    --- PASS: TestProxy/nil_response (0.00s)
    --- PASS: TestProxy/tls (0.00s)
=== RUN   TestSetupPolicy
--- PASS: TestSetupPolicy (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.01s)
=== RUN   TestSetupTLS
--- PASS: TestSetupTLS (0.00s)
=== RUN   TestSetupResolvconf
--- PASS: TestSetupResolvconf (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/grpc	(cached)
=== RUN   TestHealth
--- PASS: TestHealth (0.00s)
=== RUN   TestHealthLameduck
--- PASS: TestHealthLameduck (0.25s)
=== RUN   TestSetupHealth
--- PASS: TestSetupHealth (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/health	(cached)
=== RUN   TestLookupA
--- PASS: TestLookupA (0.00s)
=== RUN   TestLookupStaticHost
--- PASS: TestLookupStaticHost (0.00s)
=== RUN   TestLookupStaticAddr
--- PASS: TestLookupStaticAddr (0.00s)
=== RUN   TestHostCacheModification
--- PASS: TestHostCacheModification (0.00s)
=== RUN   TestHostsParse
--- PASS: TestHostsParse (0.00s)
=== RUN   TestHostsInlineParse
--- PASS: TestHostsInlineParse (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/hosts	(cached)
=== RUN   TestApex
--- PASS: TestApex (0.00s)
=== RUN   TestExternal
--- PASS: TestExternal (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/k8s_external	(cached)
=== RUN   TestExternal
--- PASS: TestExternal (0.00s)
=== RUN   TestPreserveCase
--- PASS: TestPreserveCase (0.00s)
=== RUN   TestServeDNSEmptyService
--- PASS: TestServeDNSEmptyService (0.00s)
=== RUN   TestServeDNSModeDisabled
--- PASS: TestServeDNSModeDisabled (0.00s)
=== RUN   TestServeDNSModeInsecure
--- PASS: TestServeDNSModeInsecure (0.00s)
=== RUN   TestServeDNSModeVerified
--- PASS: TestServeDNSModeVerified (0.00s)
=== RUN   TestServeDNS
--- PASS: TestServeDNS (0.00s)
=== RUN   TestServeNamespaceDNS
--- PASS: TestServeNamespaceDNS (0.00s)
=== RUN   TestNotSyncedServeDNS
--- PASS: TestNotSyncedServeDNS (0.00s)
=== RUN   TestServeDNSApex
--- PASS: TestServeDNSApex (0.00s)
=== RUN   TestWildcard
--- PASS: TestWildcard (0.00s)
=== RUN   TestEndpointHostname
--- PASS: TestEndpointHostname (0.00s)
=== RUN   TestServices
--- PASS: TestServices (0.00s)
=== RUN   TestServicesAuthority
--- PASS: TestServicesAuthority (0.00s)
=== RUN   TestMetadata
--- PASS: TestMetadata (0.00s)
=== RUN   TestFilteredNamespaceExists
--- PASS: TestFilteredNamespaceExists (0.00s)
=== RUN   TestNamespaceExposed
--- PASS: TestNamespaceExposed (0.00s)
=== RUN   TestNamespaceValid
--- PASS: TestNamespaceValid (0.00s)
=== RUN   TestNsAddr
--- PASS: TestNsAddr (0.00s)
=== RUN   TestParseRequest
--- PASS: TestParseRequest (0.00s)
=== RUN   TestParseInvalidRequest
--- PASS: TestParseInvalidRequest (0.00s)
=== RUN   TestReverse
--- PASS: TestReverse (0.00s)
=== RUN   TestKubernetesParseReverseZone
--- PASS: TestKubernetesParseReverseZone (0.00s)
=== RUN   TestKubernetesParse
--- PASS: TestKubernetesParse (0.01s)
=== RUN   TestKubernetesParseEndpointPodNames
--- PASS: TestKubernetesParseEndpointPodNames (0.00s)
=== RUN   TestKubernetesParseNoEndpoints
--- PASS: TestKubernetesParseNoEndpoints (0.00s)
=== RUN   TestKubernetesParseIgnoreEmptyService
--- PASS: TestKubernetesParseIgnoreEmptyService (0.00s)
=== RUN   TestKubernetesParseTransfer
--- PASS: TestKubernetesParseTransfer (0.00s)
=== RUN   TestKubernetesParseTTL
--- PASS: TestKubernetesParseTTL (0.00s)
=== RUN   TestKubernetesXFR
--- PASS: TestKubernetesXFR (0.00s)
=== RUN   TestKubernetesXFRNotAllowed
--- PASS: TestKubernetesXFRNotAllowed (0.00s)
=== RUN   TestEndpointsEquivalent
--- PASS: TestEndpointsEquivalent (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/kubernetes	(cached)
?   	github.com/coredns/coredns/plugin/kubernetes/object	[no test files]
=== RUN   TestLoadBalance
--- PASS: TestLoadBalance (0.00s)
=== RUN   TestLoadBalanceXFR
--- PASS: TestLoadBalanceXFR (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/loadbalance	(cached)
=== RUN   TestLoggedStatus
--- PASS: TestLoggedStatus (0.00s)
=== RUN   TestLoggedClassDenial
--- PASS: TestLoggedClassDenial (0.00s)
=== RUN   TestLoggedClassError
--- PASS: TestLoggedClassError (0.00s)
=== RUN   TestLogged
--- PASS: TestLogged (0.00s)
=== RUN   TestLogParse
--- PASS: TestLogParse (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/log	(cached)
=== RUN   TestLoop
--- PASS: TestLoop (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/loop	(cached)
=== RUN   TestMetadataServeDNS
--- PASS: TestMetadataServeDNS (0.00s)
=== RUN   TestLabelFormat
--- PASS: TestLabelFormat (0.00s)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
=== RUN   TestSetupHealth
--- PASS: TestSetupHealth (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/metadata	(cached)
=== RUN   TestMetrics
--- PASS: TestMetrics (0.08s)
=== RUN   TestPrometheusParse
--- PASS: TestPrometheusParse (0.01s)
PASS
ok  	github.com/coredns/coredns/plugin/metrics	(cached)
?   	github.com/coredns/coredns/plugin/metrics/vars	[no test files]
=== RUN   TestNsid
--- PASS: TestNsid (0.00s)
=== RUN   TestSetupNsid
--- PASS: TestSetupNsid (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/nsid	(cached)
=== RUN   TestCacheAddAndGet
--- PASS: TestCacheAddAndGet (0.00s)
=== RUN   TestCacheLen
--- PASS: TestCacheLen (0.00s)
=== RUN   TestShardAddAndGet
--- PASS: TestShardAddAndGet (0.00s)
=== RUN   TestShardLen
--- PASS: TestShardLen (0.00s)
=== RUN   TestShardEvict
--- PASS: TestShardEvict (0.00s)
=== RUN   TestShardLenEvict
--- PASS: TestShardLenEvict (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/cache	(cached)
=== RUN   TestMultiWriteMsg
--- PASS: TestMultiWriteMsg (0.00s)
=== RUN   TestMultiWrite
--- PASS: TestMultiWrite (0.00s)
=== RUN   TestNewRecorder
--- PASS: TestNewRecorder (0.00s)
=== RUN   TestWriteMsg
--- PASS: TestWriteMsg (0.00s)
=== RUN   TestWrite
--- PASS: TestWrite (0.00s)
=== RUN   TestNewServer
--- PASS: TestNewServer (0.01s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/dnstest	(cached)
=== RUN   TestDuplicateCNAME
--- PASS: TestDuplicateCNAME (0.00s)
=== RUN   TestJoin
--- PASS: TestJoin (0.00s)
=== RUN   TestExtractAddressFromReverse
--- PASS: TestExtractAddressFromReverse (0.00s)
=== RUN   TestIsReverse
--- PASS: TestIsReverse (0.00s)
=== RUN   TestMinimalTTL
--- PASS: TestMinimalTTL (0.00s)
=== RUN   TestTrimZone
--- PASS: TestTrimZone (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/dnsutil	(cached)
=== RUN   TestPostRequest
--- PASS: TestPostRequest (0.00s)
=== RUN   TestGetRequest
--- PASS: TestGetRequest (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/doh	(cached)
=== RUN   TestVersion
--- PASS: TestVersion (0.00s)
=== RUN   TestVersionNoEdns
--- PASS: TestVersionNoEdns (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/edns	(cached)
=== RUN   TestEqual
--- PASS: TestEqual (0.00s)
=== RUN   TestZero
--- PASS: TestZero (0.00s)
=== RUN   TestSetZonesFromArgs
--- PASS: TestSetZonesFromArgs (0.00s)
=== RUN   TestFallthrough
--- PASS: TestFallthrough (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/fall	(cached)
?   	github.com/coredns/coredns/plugin/pkg/fuzz	[no test files]
=== RUN   TestDebug
--- PASS: TestDebug (0.00s)
=== RUN   TestDebugx
--- PASS: TestDebugx (0.00s)
=== RUN   TestLevels
--- PASS: TestLevels (0.00s)
=== RUN   TestPlugins
--- PASS: TestPlugins (0.00s)
=== RUN   TestPluginsDateTime
--- PASS: TestPluginsDateTime (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/log	(cached)
=== RUN   TestNonWriter
--- PASS: TestNonWriter (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/nonwriter	(cached)
=== RUN   TestHostPortOrFile
--- PASS: TestHostPortOrFile (0.00s)
=== RUN   TestParseHostPort
--- PASS: TestParseHostPort (0.00s)
=== RUN   TestTransfer
--- PASS: TestTransfer (0.00s)
=== RUN   TestTransport
--- PASS: TestTransport (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/parse	(cached)
=== RUN   TestToString
--- PASS: TestToString (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/rcode	(cached)
=== RUN   TestReplacer
--- PASS: TestReplacer (0.00s)
=== RUN   TestLabels
--- PASS: TestLabels (0.00s)
=== RUN   TestMetadataReplacement
--- PASS: TestMetadataReplacement (0.00s)
=== RUN   TestMetadataMalformed
--- PASS: TestMetadataMalformed (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/replacer	(cached)
=== RUN   TestTypifyNilMsg
--- PASS: TestTypifyNilMsg (0.00s)
=== RUN   TestTypifyDelegation
--- PASS: TestTypifyDelegation (0.00s)
=== RUN   TestTypifyRRSIG
--- PASS: TestTypifyRRSIG (0.00s)
=== RUN   TestTypifyImpossible
--- PASS: TestTypifyImpossible (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/response	(cached)
=== RUN   TestDo
--- PASS: TestDo (0.00s)
=== RUN   TestDoErr
--- PASS: TestDoErr (0.00s)
=== RUN   TestDoDupSuppress
--- PASS: TestDoDupSuppress (0.10s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/singleflight	(cached)
=== RUN   TestNewTLSConfig
--- PASS: TestNewTLSConfig (0.00s)
=== RUN   TestNewTLSClientConfig
--- PASS: TestNewTLSClientConfig (0.00s)
=== RUN   TestNewTLSConfigFromArgs
--- PASS: TestNewTLSConfigFromArgs (0.00s)
=== RUN   TestNewHTTPSTransport
--- PASS: TestNewHTTPSTransport (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/tls	(cached)
?   	github.com/coredns/coredns/plugin/pkg/trace	[no test files]
?   	github.com/coredns/coredns/plugin/pkg/transport	[no test files]
=== RUN   TestForEach
--- PASS: TestForEach (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/uniq	(cached)
=== RUN   TestUp
--- PASS: TestUp (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pkg/up	(cached)
?   	github.com/coredns/coredns/plugin/pkg/upstream	[no test files]
=== RUN   TestPProf
--- PASS: TestPProf (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/pprof	(cached)
=== RUN   TestReady
--- PASS: TestReady (0.01s)
=== RUN   TestSetupReady
--- PASS: TestSetupReady (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/ready	(cached)
=== RUN   TestSetupReload
--- PASS: TestSetupReload (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/reload	(cached)
=== RUN   TestRewriteIllegalName
--- PASS: TestRewriteIllegalName (0.00s)
=== RUN   TestRewriteNamePrefixSuffix
--- PASS: TestRewriteNamePrefixSuffix (0.00s)
=== RUN   TestNewNameRule
--- PASS: TestNewNameRule (0.00s)
    name_test.go:102: Test 0: PASS, passed as expected: (stop) [exact srv3.coredns.rocks srv4.coredns.rocks]
    name_test.go:102: Test 1: PASS, passed as expected: (stop) [srv1.coredns.rocks srv2.coredns.rocks]
    name_test.go:102: Test 2: PASS, passed as expected: (stop) [suffix coredns.rocks coredns.rocks.]
    name_test.go:102: Test 3: PASS, passed as expected: (stop) [suffix coredns.rocks. coredns.rocks]
    name_test.go:102: Test 4: PASS, passed as expected: (stop) [suffix coredns.rocks. coredns.rocks.]
    name_test.go:102: Test 5: PASS, passed as expected: (stop) [regex srv1.coredns.rocks 10]
    name_test.go:102: Test 6: PASS, passed as expected: (stop) [regex (.*).coredns.rocks 10]
    name_test.go:102: Test 7: PASS, passed as expected: (stop) [regex (.*).coredns.rocks {1}.coredns.rocks]
    name_test.go:106: Test 8: PASS, failed as expected: (stop) [regex (.*).coredns.rocks {1}.{2}.coredns.rocks]: the rewrite regex pattern ({1}.{2}.coredns.rocks) uses more subexpressions than its corresponding matching regex pattern ((.*).coredns.rocks)
    name_test.go:102: Test 9: PASS, passed as expected: (stop) [regex staging.mydomain.com aws-loadbalancer-id.us-east-1.elb.amazonaws.com]
    name_test.go:122: Test 0: PASS, passed as expected: (stop) [stop name exact srv3.coredns.rocks srv4.coredns.rocks]
    name_test.go:122: Test 1: PASS, passed as expected: (stop) [stop name srv1.coredns.rocks srv2.coredns.rocks]
    name_test.go:122: Test 2: PASS, passed as expected: (stop) [stop name suffix coredns.rocks coredns.rocks.]
    name_test.go:122: Test 3: PASS, passed as expected: (stop) [stop name suffix coredns.rocks. coredns.rocks]
    name_test.go:122: Test 4: PASS, passed as expected: (stop) [stop name suffix coredns.rocks. coredns.rocks.]
    name_test.go:122: Test 5: PASS, passed as expected: (stop) [stop name regex srv1.coredns.rocks 10]
    name_test.go:122: Test 6: PASS, passed as expected: (stop) [stop name regex (.*).coredns.rocks 10]
    name_test.go:122: Test 7: PASS, passed as expected: (stop) [stop name regex (.*).coredns.rocks {1}.coredns.rocks]
    name_test.go:126: Test 8: PASS, failed as expected: (stop) [stop name regex (.*).coredns.rocks {1}.{2}.coredns.rocks]: the rewrite regex pattern ({1}.{2}.coredns.rocks) uses more subexpressions than its corresponding matching regex pattern ((.*).coredns.rocks)
    name_test.go:122: Test 9: PASS, passed as expected: (stop) [stop name regex staging.mydomain.com aws-loadbalancer-id.us-east-1.elb.amazonaws.com]
=== RUN   TestResponseReverter
--- PASS: TestResponseReverter (0.00s)
=== RUN   TestNewRule
--- PASS: TestNewRule (0.00s)
=== RUN   TestRewrite
--- PASS: TestRewrite (0.00s)
=== RUN   TestRewriteEDNS0Local
--- PASS: TestRewriteEDNS0Local (0.00s)
=== RUN   TestEdns0LocalMultiRule
--- PASS: TestEdns0LocalMultiRule (0.00s)
=== RUN   TestRewriteEDNS0LocalVariable
--- PASS: TestRewriteEDNS0LocalVariable (0.00s)
=== RUN   TestRewriteEDNS0Subnet
--- PASS: TestRewriteEDNS0Subnet (0.00s)
=== RUN   TestParse
--- PASS: TestParse (0.00s)
=== RUN   TestNewTTLRule
--- PASS: TestNewTTLRule (0.00s)
=== RUN   TestTtlRewrite
--- PASS: TestTtlRewrite (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/rewrite	(cached)
=== RUN   TestRoot
--- PASS: TestRoot (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/root	(cached)
=== RUN   TestRoute53
--- PASS: TestRoute53 (0.00s)
=== RUN   TestMaybeUnescape
--- PASS: TestMaybeUnescape (0.00s)
=== RUN   TestSetupRoute53
--- PASS: TestSetupRoute53 (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/route53	(cached)
=== RUN   TestSecondaryParse
--- PASS: TestSecondaryParse (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/secondary	(cached)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
=== RUN   TestSetupParse
--- PASS: TestSetupParse (0.01s)
=== RUN   TestHandler
--- PASS: TestHandler (0.01s)
=== RUN   TestMultiSection
--- PASS: TestMultiSection (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/template	(cached)
=== RUN   TestTempFile
--- PASS: TestTempFile (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/test	(cached)
=== RUN   TestTLS
--- PASS: TestTLS (0.00s)
=== RUN   TestTLSClientAuthentication
--- PASS: TestTLSClientAuthentication (0.02s)
PASS
ok  	github.com/coredns/coredns/plugin/tls	(cached)
=== RUN   TestTraceParse
--- PASS: TestTraceParse (0.00s)
=== RUN   TestStartup
--- PASS: TestStartup (0.00s)
=== RUN   TestTrace
=== RUN   TestTrace/NXDOMAIN
=== RUN   TestTrace/NOERROR
--- PASS: TestTrace (0.00s)
    --- PASS: TestTrace/NXDOMAIN (0.00s)
    --- PASS: TestTrace/NOERROR (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/trace	(cached)
=== RUN   TestSetup
--- PASS: TestSetup (0.00s)
=== RUN   TestWhoami
--- PASS: TestWhoami (0.00s)
PASS
ok  	github.com/coredns/coredns/plugin/whoami	(cached)

ironcladlou · 2019-07-10T18:38:54Z

Thanks for all your work on this!

/lgtm
/approve

celebdor · 2019-07-10T18:41:35Z

Thanks for letting me collaborate :-)

Add github.com/openshift/coredns-mdns plugin

openshift-ci-robot requested review from deads2k and derekwaynecarr June 20, 2019 11:23

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 20, 2019

celebdor mentioned this pull request Jun 20, 2019

openstack: Add mdns plugin for coredns static pods #12

Closed

bcrochet approved these changes Jun 20, 2019

View reviewed changes

cybertron approved these changes Jun 20, 2019

View reviewed changes

openshift-ci-robot assigned knobunc Jun 28, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2019

Add github.com/openshift/coredns-mdns plugin

8fe3d54

This plugin allows for discovering hosts via mDNS browsing, which means that those nodes are then exposed via normal unicast DNS.

celebdor force-pushed the mdns branch from e0d5b9b to 8fe3d54 Compare July 10, 2019 14:29

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 10, 2019

openshift-ci-robot assigned ironcladlou Jul 10, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2019

openshift-merge-robot merged commit 51569b2 into openshift:master Jul 10, 2019

celebdor deleted the mdns branch July 10, 2019 22:59

Miciah mentioned this pull request Jan 22, 2022

Bug 2043801: Merge 1.8.7 #70

Merged

bentito pushed a commit to bentito/coredns that referenced this pull request Nov 21, 2025

Merge pull request openshift#14 from celebdor/mdns

0ea7dba

Add github.com/openshift/coredns-mdns plugin

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add github.com/openshift/coredns-mdns plugin #14

Add github.com/openshift/coredns-mdns plugin #14

Uh oh!

celebdor commented Jun 20, 2019

Uh oh!

celebdor commented Jun 20, 2019

Uh oh!

cybertron left a comment

Uh oh!

knobunc commented Jun 28, 2019

Uh oh!

ironcladlou commented Jun 28, 2019

Uh oh!

cybertron commented Jun 28, 2019

Uh oh!

ironcladlou commented Jul 3, 2019

Uh oh!

knobunc commented Jul 10, 2019

Uh oh!

celebdor commented Jul 10, 2019

Uh oh!

ironcladlou commented Jul 10, 2019

Uh oh!

celebdor commented Jul 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Add github.com/openshift/coredns-mdns plugin #14

Add github.com/openshift/coredns-mdns plugin #14

Uh oh!

Conversation

celebdor commented Jun 20, 2019

1. Why is this pull request needed and what does it do?

Uh oh!

celebdor commented Jun 20, 2019

Uh oh!

cybertron left a comment

Choose a reason for hiding this comment

Uh oh!

knobunc commented Jun 28, 2019

Uh oh!

ironcladlou commented Jun 28, 2019

Uh oh!

cybertron commented Jun 28, 2019

Uh oh!

ironcladlou commented Jul 3, 2019

Uh oh!

knobunc commented Jul 10, 2019

Uh oh!

celebdor commented Jul 10, 2019

Uh oh!

ironcladlou commented Jul 10, 2019

Uh oh!

celebdor commented Jul 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants