[WIP] Bug 1980531: additionalHelpActions 'HelpMenu' ConsoleLinks not translated

[kdoberst]

Addresses Bug 1980531

In the help menu, the "Learning Portal" and "OpenShift Blog" links are brought into the console code so they can be translated.

Note: This PR should be merged after openshift/console-operator#565 to prevent the help links from being duplicated.

[openshift-ci]

@kdoberst: This pull request references Bugzilla bug 1980531, which is invalid:

• expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[WIP] Bug 1980531: additionalHelpActions 'HelpMenu' ConsoleLinks not translated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kdoberst]

/bugzilla refresh

[openshift-ci]

@kdoberst: This pull request references Bugzilla bug 1980531, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

Thanks @kdoberst

The "Learning Portal" and "OpenShift Blog" links will always show and cannot be deleted. There needs to be some investigation if it is possible for users to remove these links in the current system.

It's not currently possible for admins to remove these links. The operator will recreate them if an admin deletes them.

We should be able to add the release.openshift.io/delete: "true" annotation in the manifests in the console-operator repo to remove the existing ConsoleLink resources.

[openshift-ci]

@kdoberst: This pull request references Bugzilla bug 1980531, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

[WIP] Bug 1980531: additionalHelpActions 'HelpMenu' ConsoleLinks not translated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kdoberst]

We should be able to add the release.openshift.io/delete: "true" annotation in the manifests in the console-operator repo to remove the existing ConsoleLink resources.

This has been verified and there is PR to put those changes into the console-operator.

[openshift-ci]

@kdoberst: This pull request references Bugzilla bug 1980531, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

Bug 1980531: additionalHelpActions 'HelpMenu' ConsoleLinks not translated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtaylor113]

lgtm, one issue to include new translated sections in e2e tests :-)

If the additional links are now translated we should remove the .first() here in frontend/packages/integration-tests-cypress/tests/i18n/pseudolocalization.spec.ts in order to test pseudolocalization of all help menu sections.

[openshift-ci]

@kdoberst: This pull request references Bugzilla bug 1980531, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

[WIP] Bug 1980531: additionalHelpActions 'HelpMenu' ConsoleLinks not translated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kdoberst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [kdoberst]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@kdoberst: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/kubevirt-plugin	e60f69e7d8432ab492d12da3a04ab3b9ea0a2f70	link	/test kubevirt-plugin
ci/prow/frontend	cbd349d	link	/test frontend
ci/prow/e2e-gcp-console	cbd349d	link	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kdoberst]

There was an error rebasing. Closing this PR and opening #9811

[openshift-ci]

@kdoberst: An error was encountered getting external tracker bugs for bug 1980531 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

could not parse external identifier "openshift/console/pull/9385#pullrequestreview-702386658" as pull: invalid pull identifier: could not parse 9385#pullrequestreview-702386658 as number: strconv.Atoi: parsing "9385#pullrequestreview-702386658": invalid syntax

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

[WIP] Bug 1980531: additionalHelpActions 'HelpMenu' ConsoleLinks not translated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.