Bug 1605136 - Let users clear default fields with template service broker#711
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Dec 2, 2018
Merged
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
spadgett
force-pushed
the
schema-form-empty-values
branch
from
450dc4d to
604921c
Compare
openshift-ci-robot
added
size/M
Member
Author
|
jenkins rebuild |
Member
Author
|
The upstream origin change is in the merge queue. @rhamilto ptal |
rhamilto
reviewed
Nov 28, 2018
| autoFocus={autofocus} | ||
| value={value == null ? '' : value} | ||
| {...inputProps} | ||
| onChange={(event) => onChange(event.target.value)} |
Member
There was a problem hiding this comment.
Nit: you don't use the parens around the argument below.
spadgett
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires openshift/origin#21371
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1605136
@johnkim76 @bparees
/assign @rhamilto