Skip to content

Remove method searchYAML from console-shared #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 16, 2020
Merged

Remove method searchYAML from console-shared #5074

openshift-merge-robot merged 1 commit into from
Apr 16, 2020

Conversation

@rhrazdil
Copy link

@rhrazdil rhrazdil commented Apr 16, 2020

As pointed out by @spadgett in #2125,
searchYAML has several pitfalls and should not be used.

Removed this method from console-shared and updated test cases that used this method.

@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Apr 16, 2020
spadgett
spadgett reviewed Apr 16, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.clone.scenario.ts Outdated
Copy link
Member

@spadgett spadgett Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider _.has or optional chaining here.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-7.html#optional-chaining

Copy link
Author

@rhrazdil rhrazdil Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

frontend/packages/kubevirt-plugin/integration-tests/tests/vm.clone.scenario.ts Outdated
Copy link
Member

@spadgett spadgett Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to pass the third arg here. If no default is passed, undefined would be returned anyway.

Copy link
Author

@rhrazdil rhrazdil Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to be explicit, but yeah, it's unnecessary. Removed it.

@rhrazdil rhrazdil force-pushed the refactor-console-shared branch from 638d8e9 to 5cb3ae0 Compare April 16, 2020 18:01
@rhrazdil
Copy link
Author

rhrazdil commented Apr 16, 2020

CI keeps failing
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2020
@spadgett
Copy link
Member

spadgett commented Apr 16, 2020

/retest

spadgett
spadgett approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@spadgett
Copy link
Member

spadgett commented Apr 16, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit 293e553 into openshift:master Apr 16, 2020
@spadgett spadgett added this to the v4.5 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@jelkosz jelkosz Awaiting requested review from jelkosz

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

v4.5

Development

Successfully merging this pull request may close these issues.

4 participants

@rhrazdil @spadgett @openshift-ci-robot @openshift-merge-robot