Skip to content

Metrics and Resource-sidebar updated to pf4 Button component#2967

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sg00dwin:groupB-pf4-btns
Oct 17, 2019
Merged

Metrics and Resource-sidebar updated to pf4 Button component#2967
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sg00dwin:groupB-pf4-btns

Conversation

@sg00dwin
Copy link
Copy Markdown
Member

@sg00dwin sg00dwin commented Oct 14, 2019

Screen Shot 2019-10-08 at 4 19 23 PM

Screen Shot 2019-10-14 at 12 19 51 PM

Screen Shot 2019-10-14 at 12 20 13 PM

@sg00dwin sg00dwin requested a review from spadgett October 14, 2019 16:44
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/monitoring Related to monitoring size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2019
@sg00dwin
Copy link
Copy Markdown
Member Author

sg00dwin commented Oct 14, 2019

/retest

@sg00dwin sg00dwin force-pushed the groupB-pf4-btns branch 4 times, most recently from a51fcbf to 36bf78f Compare October 16, 2019 14:36
@sg00dwin
Copy link
Copy Markdown
Member Author

sg00dwin commented Oct 16, 2019

/retest

@spadgett
Copy link
Copy Markdown
Member

spadgett commented Oct 16, 2019

/assign @rhamilto
/uncc @alecmerdler

@openshift-ci-robot openshift-ci-robot removed the request for review from alecmerdler October 16, 2019 18:02
rhamilto
rhamilto reviewed Oct 16, 2019
View reviewed changes
Comment thread frontend/public/components/sidebars/resource-sidebar.jsx Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is changing significantly in #2889, so I'd hold off on migrating these buttons.

Copy link
Copy Markdown
Member

@rhamilto rhamilto Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now included in #2889, so please drop the changes in this PR.

rhamilto
rhamilto reviewed Oct 16, 2019
View reviewed changes
Comment thread frontend/public/components/sidebars/resource-sidebar.jsx Outdated
Copy link
Copy Markdown
Member

@rhamilto rhamilto Oct 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now included in #2889, so please drop the changes in this PR.

Comment thread frontend/public/style/_layout.scss Outdated
Comment thread frontend/public/style/_overrides.scss Outdated
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2019
rhamilto
rhamilto reviewed Oct 16, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f0e8839 into openshift:master Oct 17, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 18, 2019
@sg00dwin sg00dwin deleted the groupB-pf4-btns branch December 9, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto left review comments

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@sg00dwin @spadgett @openshift-ci-robot @openshift-bot @rhamilto @openshift-merge-robot