Skip to content

Enable prettier on frontend/ #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 30, 2019
Merged

Enable prettier on frontend/ #2865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
18 changes: 2 additions & 16 deletions frontend/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"root": true,
"env": {
"browser": true,
"es6": true,
Expand All @@ -9,6 +10,7 @@
"plugin:import/errors",
"plugin:import/warnings",
"plugin:react/recommended",
"plugin:console/prettier",
],
"parser": "@typescript-eslint/parser",
"parserOptions": {
Expand All @@ -26,24 +28,17 @@
"@typescript-eslint",
],
"rules": {
"brace-style": 2,
"camelcase": 2,
"comma-dangle": ["error", "always-multiline"],
"consistent-return": 0,
"consistent-this": [1, "that"],
"curly": [2, "all"],
"default-case": [2],
"dot-notation": [2],
"eol-last": [2, "unix"],
"no-multiple-empty-lines": [2, {"max": 2, "maxEOF": 0}],
"eqeqeq": [2, "allow-null"],
"guard-for-in": 2,
"import/no-unresolved": ["error"],
"import/no-duplicates": ["error"],
"indent": [2, 2, {"SwitchCase": 1, "VariableDeclarator": 2}],
"jsx-quotes": "error",
"keyword-spacing": "error",
"linebreak-style": [2, "unix"],
"max-nested-callbacks": [1, 4],
"no-alert": 2,
"no-caller": 2,
Expand All @@ -53,31 +48,22 @@
"no-else-return": ["error"],
"no-global-strict": 0,
"no-irregular-whitespace": ["error"],
"no-multi-spaces": [2],
"no-shadow": ["error"],
"no-trailing-spaces": ["error"],
"no-underscore-dangle": 0,
"@typescript-eslint/no-unused-vars": ["error", {"varsIgnorePattern": "React", "args": "after-used"}],
"@typescript-eslint/no-use-before-define": 2,
"no-var": 2,
"object-shorthand": ["error", "properties"],
"prefer-const": ["error", {"destructuring": "all"}],
"prefer-template": 2,
"quotes": [2, "single"],
"radix": 2,
"react/jsx-curly-spacing": 2,
"react/jsx-equals-spacing": 2,
"react/jsx-no-duplicate-props": 2,
"react/no-string-refs": 1,
"react/jsx-uses-react": "error",
"react/jsx-uses-vars": "error",
"react/jsx-tag-spacing": 2,
"react/no-unknown-property": "error",
"react/prop-types": 0,
"react/self-closing-comp": ["error", {"component": true, "html": false}],
"semi": 2,
"space-before-function-paren": ["error", "never"],
"wrap-iife": [2, "inside"],
"react-hooks/rules-of-hooks": "error",
"react-hooks/exhaustive-deps": "warn",
"react/display-name": 0,
Expand Down
25 changes: 12 additions & 13 deletions frontend/.vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
{
// TODO uncomment once we enable new eslint & prettier support across the entire project
// "[javascript]": {
// "editor.formatOnSave": true
// },
// "[javascriptreact]": {
// "editor.formatOnSave": true
// },
// "[typescript]": {
// "editor.formatOnSave": true
// },
// "[typescriptreact]": {
// "editor.formatOnSave": true
// },
"[javascript]": {
"editor.formatOnSave": true
Copy link
Member Author

@spadgett spadgett Sep 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christianvogt fyi, i went ahead and uncommented these lines to always enable prettier in vscode

},
"[javascriptreact]": {
"editor.formatOnSave": true
},
"[typescript]": {
"editor.formatOnSave": true
},
"[typescriptreact]": {
"editor.formatOnSave": true
},

"eslint.validate": [
"javascript",
Expand Down
Loading