Skip to content

Improve type checking of object metadata #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 30, 2019
Merged

Improve type checking of object metadata #2848

openshift-merge-robot merged 1 commit into from
Sep 30, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Sep 26, 2019

/assign @christianvogt
/kind cleanup

@openshift-ci-robot openshift-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. component/core Related to console core functionality component/dev-console Related to dev-console component/olm Related to OLM labels Sep 26, 2019
@spadgett spadgett added this to the v4.3 milestone Sep 26, 2019
spadgett
spadgett commented Sep 26, 2019
View reviewed changes
alecmerdler
alecmerdler reviewed Sep 26, 2019
View reviewed changes
frontend/packages/dev-console/src/components/topology/__tests__/topology-test-data.ts Outdated
Copy link
Contributor

@alecmerdler alecmerdler Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol what happened here

Copy link
Contributor

@christianvogt christianvogt Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Garbage in, garbage out :)

@spadgett
Copy link
Member Author

spadgett commented Sep 26, 2019

Updated

@spadgett spadgett mentioned this pull request Sep 26, 2019
Merged
alecmerdler
alecmerdler approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@spadgett
Copy link
Member Author

spadgett commented Sep 26, 2019

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2019
@spadgett
Copy link
Member Author

spadgett commented Sep 27, 2019

/retest

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Sep 28, 2019

/retest

@christianvogt
Copy link
Contributor

christianvogt commented Sep 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, christianvogt, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ef27317 into openshift:master Sep 30, 2019
@spadgett spadgett deleted the metadata-types branch September 30, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

2 more reviewers

@christianvogt christianvogt christianvogt left review comments

@alecmerdler alecmerdler alecmerdler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alecmerdler alecmerdler

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/olm Related to OLM kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

5 participants

@spadgett @christianvogt @openshift-ci-robot @alecmerdler @openshift-merge-robot