Skip to content

Conversation

@alecmerdler
Copy link
Contributor

Description

The onChange handlers were missing when ConfigureUpdateStrategy was refactored to be a fully controlled function component.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1753018

@openshift-ci-robot
Copy link
Contributor

@alecmerdler: This pull request references Bugzilla bug 1753018, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1753018: Fix Update Strategy Modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/olm Related to OLM size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@alecmerdler alecmerdler requested review from spadgett and removed request for jcaianirh and josephschorr September 17, 2019 20:18
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9874340 into openshift:master Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

@alecmerdler: All pull requests linked via external trackers have merged. Bugzilla bug 1753018 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1753018: Fix Update Strategy Modal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.2 milestone Sep 18, 2019
@alecmerdler alecmerdler deleted the bugzilla-1753018 branch September 18, 2019 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants