Bug 1752829: select nodes labeling info fixed #2743
Conversation
|
@bipuladh: This pull request references Bugzilla bug 1752829, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
|
Hi @bipuladh. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
Please specify a better commit message. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@cloudbehl: This pull request references Bugzilla bug 1752829, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/approve |
openshift-ci-robot
added
the
approved
|
@bipuladh Can you please add a screenshot of how its looking now. |
|
@bipuladh: This pull request references Bugzilla bug 1752829, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@bipuladh: This pull request references Bugzilla bug 1752829, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
| Service.These nodes will also be tainted with | |
| Service. These nodes will also be tainted with |
|
@bipuladh: This pull request references Bugzilla bug 1752829, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bipuladh
force-pushed
the
bug_fix_1752829
branch
from
800ace3 to
5ba036d
Compare
-Adds more information about label and taints.
bipuladh
force-pushed
the
bug_fix_1752829
branch
from
5ba036d to
a9e7ea1
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bipuladh, cloudbehl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bipuladh: All pull requests linked via external trackers have merged. Bugzilla bug 1752829 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
This PR updates the explanation under the select node's label in the create OCS service form. Since the selected nodes will be labeled with
cluster.ocs.openshift.io/openshift-storage=""we are letting the users know about these changes in the nodes. These nodes will also be tainted withnode.ocs.openshift.io/storage=true:NoSchedule. However, since the previous explanation was ambiguous the updated statement lets the user know that these taints have been added to schedule only OCS components and nothing else. It also lets the user know that they should have other additional nodes that are not tainted so that there are nodes where the other workloads can be scheduled.Screenshot:
