Bug 1751762: OCS Operator version in details card fix #2736
Conversation
openshift-ci-robot
added
component/ceph
|
Hi @bipuladh. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
There was a problem hiding this comment.
const itemsData = _.get(items, 'data');
const obj = itemsData.find(item => _.get(item, 'spec.name') === 'ocs-operator');
return _.get(obj, 'status.currentCSV')
There was a problem hiding this comment.
Also define the type of item object
There was a problem hiding this comment.
move ocs-operator to constants
There was a problem hiding this comment.
Also _.findWhere can be used.
bipuladh
force-pushed
the
version_patch
branch
from
d32af75 to
3bb3bbd
Compare
openshift-ci-robot
added
size/M
There was a problem hiding this comment.
type not required as it's inherited from the itemsData.
| (item: K8sResourceKind) => _.get(item, 'spec.name') === OCS_OPERATOR, | |
| (item) => _.get(item, 'spec.name') === OCS_OPERATOR, |
bipuladh
force-pushed
the
version_patch
branch
from
3bb3bbd to
a515e88
Compare
bipuladh
changed the title
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
|
/bugzilla refresh |
|
@cloudbehl: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bipuladh
changed the title
bipuladh
changed the title
|
@bipuladh: This pull request references Bugzilla bug 1751762, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anmolsachan, bipuladh, cloudbehl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@spadgett: This pull request references Bugzilla bug 1751762, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bipuladh: All pull requests linked via external trackers have merged. Bugzilla bug 1751762 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
The version of the OCS operator is fixed.