Bug 1752070: Modify the conditions for health status #2732
Conversation
afreen23
commented
Sep 16, 2019
afreen23
commented
- Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1752070
- Using Phase for the noobaa resource as status for MCG up/down
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@afreen23: This pull request references Bugzilla bug 1752070, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
size/S
|
/bugzilla refresh |
|
@afreen23: This pull request references Bugzilla bug 1752070, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign cloudbehl |
|
/test e2e-aws-console-olm |
|
/bugzilla refresh |
|
@afreen23: This pull request references Bugzilla bug 1752070, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
if noobaPhase is undefined then this will break.
| if (!noobaaSystemData || (noobaaPhase && noobaaPhase !== 'Ready')) { | |
| if (!noobaaSystemData || (noobaaPhase !== 'Ready')) { |
There was a problem hiding this comment.
Will not break actually, put on purpose, but not required now.
I have made status Unavailable when there is error.
Its good to use now noobaaPhase !== 'Ready'.
There was a problem hiding this comment.
| const noobaaPhase = _.get(noobaaSystemData, 'status.phase'); | |
| const noobaaPhase = _.get(noobaaSystemData, 'status.phase', ''); |
There was a problem hiding this comment.
Would still give a falsey value. '' is falsey which would make it equivalent to using it as it is since undefined is also a falsey value.
- Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1752070 - Using Phase for the noobaa resource as status for MCG up/down Signed-off-by: Afreen Rahman <[email protected]>
afreen23
force-pushed
the
health-card-bugfix
branch
from
db235ca to
8363e3e
Compare
openshift-ci-robot
added
size/M
|
/bugzilla refresh |
|
@afreen23: This pull request references Bugzilla bug 1752070, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@spadgett: This pull request references Bugzilla bug 1752070, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afreen23, gnehapk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@afreen23: All pull requests linked via external trackers have merged. Bugzilla bug 1752070 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
