Skip to content

Conversation

@bipuladh
Copy link
Contributor

Bugfix to add the timestamp in the top consumer card in the Ceph dashboard.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2019
@openshift-ci-robot
Copy link
Contributor

Hi @bipuladh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bipuladh
Copy link
Contributor Author

/assign @cloudbehl

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Sep 16, 2019
@bipuladh bipuladh changed the title Added timestamp to data point labels Bug 1748559 - Data point labels in chart in Top Consumers panel of Persistent Storage lacks timestamps fix Sep 17, 2019
@cloudbehl
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2019
@cloudbehl
Copy link
Contributor

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 17, 2019
@bipuladh bipuladh changed the title Bug 1748559 - Data point labels in chart in Top Consumers panel of Persistent Storage lacks timestamps fix Bug 1748559: Data point labels in chart in Top Consumers panel of Persistent Storage lacks timestamps fix Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1748559, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "OCS 4.2.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1748559: Data point labels in chart in Top Consumers panel of Persistent Storage lacks timestamps fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 17, 2019
@bipuladh bipuladh changed the title Bug 1748559: Data point labels in chart in Top Consumers panel of Persistent Storage lacks timestamps fix Bug 1748559:Data point labels in chart in Top Consumers panel of Persistent Storage lacks timestamps fix Sep 17, 2019
@bipuladh
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@bipuladh: This pull request references Bugzilla bug 1748559, which is invalid:

  • expected the bug to target the "4.2.0" release, but it targets "OCS 4.2.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cloudbehl
Copy link
Contributor

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@spadgett spadgett added this to the v4.2 milestone Sep 17, 2019
@spadgett
Copy link
Member

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

@spadgett: This pull request references Bugzilla bug 1748559, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 85b70a5 into openshift:master Sep 17, 2019
@openshift-ci-robot
Copy link
Contributor

@bipuladh: All pull requests linked via external trackers have merged. Bugzilla bug 1748559 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1748559:Data point labels in chart in Top Consumers panel of Persistent Storage lacks timestamps fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants