Bug 1748219: Detect baremetal platform

[jtomasek]

Since the baremetal operator CRD can be installed on non baremetal
cluster, this change introduces additional baremetal platform detection
by checking the infrastructure.cluster platform which is used to enable
metal3-plugin

https://bugzilla.redhat.com/show_bug.cgi?id=1748219

TODO:

• enable dashboard extension items required prop to be `string | string[]'

[jtomasek]

/assign @vojtechszocs

[rawagner]

it would be better to just go with required: string[] IMO.

[rawagner]

actually, nevermind. For 4.3 we will have proper plugin gating and using string | string[] will result in smaller change

[vojtechszocs]

I'd prefer string | string[] here to minimize changes in specific plugins.

[vojtechszocs]

@jtomasek LGTM overall, please check my inline comments.

[vojtechszocs]

Maybe I'm missing something, but shouldn't we set the flag like this?

(infra: K8sResourceKind) => dispatch(setFlag(FLAGS.BAREMETAL, getInfrastructurePlatform(infra) === 'BareMetal'))

[jtomasek]

Done

[vojtechszocs]

It seems that existing detectFoo functions pass success and error handlers as part of then invocation.

Suggested change:

const detectBaremetalPlatform = dispatch => k8sGet(InfrastructureModel, 'cluster')
  .then(
    (infra: K8sResourceKind) => {
      dispatch(setFlag(FLAGS.BAREMETAL, getInfrastructurePlatform(infra) === 'BareMetal'))
    },
    (err) => {
      _.get(err, 'response.status') === 404
        ? dispatch(setFlag(FLAGS.BAREMETAL, false))
        : handleError(err, FLAGS.BAREMETAL, dispatch, detectBaremetalPlatform);
    }
  );

[jtomasek]

I believe that handling errors using onRejected instead of using catch is often considered anti-pattern as using catch will also catch the errors occurring during onFulfilled.

I've aligned the code to other 'detect' functions though.

[vojtechszocs]

Please add a TODO comment above this line:

// TODO(vojtech): move this flag definition to metal3-plugin via ActionFeatureFlag extension

[jtomasek]

Done

[vojtechszocs]

For better consistency, whenever we add new shared selectors, we should also update existing code to use them instead of repeating similar code across multiple places.

This can be done as a follow-up, of course.

[openshift-ci-robot]

@jtomasek: This pull request references Bugzilla bug 1748219, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1748219: Detect baremetal platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vojtechszocs]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@jtomasek: All pull requests linked via external trackers have merged. Bugzilla bug 1748219 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1748219: Detect baremetal platform

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.