-
Notifications
You must be signed in to change notification settings - Fork 667
[WIP] Alertmanager Configuration #2497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Alertmanager Configuration #2497
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yaacov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@suomiy @rawagner @mareklibra please review. |
|
/hold |
ec31864 to
c862e84
Compare
|
/cc @kyoto @dtaylor113 We should coordinate as @dtaylor113 had started looking at this. |
|
Hi @yaacov, I think we are both working on the same Story. I have already added [in a dev branch, not yet posted] a Configuration tab as well as Alert Routing section: I also have implemented the edit modal: I started working on this because I am assigned the JIRA story: https://jira.coreos.com/browse/CONSOLE-1581 |
|
@dtaylor113 @spadgett Thanks ! |
Actually, "CNV-2859" is talking about the left hand nav menu, under 'Monitoring' , removing 'Alerts' and 'Silences' and replacing with 'Alerting' -which has already been done for 4.2. So, "CNV-2859" is already completed. |
@dtaylor113 Ahh... the description did look suspicious :-) So 2859 is done :-) |
Yes, I believe so. Did you mean https://jira.coreos.com/browse/CNV-2861 for this PR? Also, https://jira.coreos.com/browse/CNV-2860 is also DONE |
|
closing in favour of @dtaylor113 's work. |
👍 Actually no, I was assign 2859, and continue using the design :-) so it ended up 2861 😄 |


Add a "Configuration" tab to the "Alerting" page.