Skip to content

Conversation

@yaacov
Copy link
Member

@yaacov yaacov commented Aug 27, 2019

Add a "Configuration" tab to the "Alerting" page.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/core Related to console core functionality component/monitoring Related to monitoring size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yaacov
To complete the pull request process, please assign bparees
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member Author

yaacov commented Aug 27, 2019

@suomiy @rawagner @mareklibra please review.

@spadgett
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2019
@yaacov yaacov force-pushed the use-direct-links-when-not-proxing-prometheus branch from ec31864 to c862e84 Compare August 27, 2019 13:13
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2019
@spadgett
Copy link
Member

/cc @kyoto @dtaylor113

We should coordinate as @dtaylor113 had started looking at this.

@dtaylor113
Copy link
Contributor

dtaylor113 commented Aug 27, 2019

Hi @yaacov, I think we are both working on the same Story. I have already added [in a dev branch, not yet posted] a Configuration tab as well as Alert Routing section:
image

I also have implemented the edit modal:
image

I started working on this because I am assigned the JIRA story: https://jira.coreos.com/browse/CONSOLE-1581
Based on these designs: https://openshift.github.io/openshift-origin-design/web-console/monitoring/alertmanager-config/alertmanager-config

@yaacov
Copy link
Member Author

yaacov commented Aug 27, 2019

@dtaylor113 @spadgett Thanks !
It looks like https://jira.coreos.com/browse/CNV-2859 is very close related / duplicate ?

@dtaylor113
Copy link
Contributor

dtaylor113 commented Aug 27, 2019

@dtaylor113 @spadgett Thanks !
It looks like https://jira.coreos.com/browse/CNV-2859 is very close related / duplicate ?

Actually, "CNV-2859" is talking about the left hand nav menu, under 'Monitoring' , removing 'Alerts' and 'Silences' and replacing with 'Alerting' -which has already been done for 4.2. So, "CNV-2859" is already completed.

@yaacov
Copy link
Member Author

yaacov commented Aug 27, 2019

Actually, "CNV-2859" is talking about the left hand nav menu, under 'Monitoring' , removing 'Alerts' and 'Silences' and replacing with 'Alerting' -which has already been done for 4.2.

@dtaylor113 Ahh... the description did look suspicious :-)

So 2859 is done :-)

@dtaylor113
Copy link
Contributor

dtaylor113 commented Aug 27, 2019

So 2859 is done :-)

Yes, I believe so. Did you mean https://jira.coreos.com/browse/CNV-2861 for this PR?

Also, https://jira.coreos.com/browse/CNV-2860 is also DONE

@yaacov
Copy link
Member Author

yaacov commented Aug 27, 2019

closing in favour of @dtaylor113 's work.

@yaacov yaacov closed this Aug 27, 2019
@yaacov
Copy link
Member Author

yaacov commented Aug 27, 2019

Yes, I believe so. Did you mean https://jira.coreos.com/browse/CNV-2861 for this PR?

👍 Actually no, I was assign 2859, and continue using the design :-) so it ended up 2861 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core Related to console core functionality component/monitoring Related to monitoring do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants