-
Notifications
You must be signed in to change notification settings - Fork 667
Improve the use of ESLint configs #2472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the use of ESLint configs #2472
Conversation
b1ccde3 to
9f7f1e9
Compare
|
Not sure why this depends on #2053. |
9f7f1e9 to
2091e4a
Compare
|
@christianvogt How do you feel about those pre-composed ESLint configs? I'd expect
The |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
Depends on #2053, please review the second commit only.
This PR adds pre-composed ESLint configs representing common code archetypes:
react-typescript-prettier- applies to:packagesnode-typescript-prettier- applies to:packages/console-plugin-sdk/src/codegenpackages/kubevirt-plugin/integration-testsThe
import/no-extraneous-dependenciesfix for monorepo (which is a common concern) is moved into the pre-composed configs.This should (hopefully) lead to small and focused
.eslintrcfiles./cc @christianvogt
FYI @spadgett @rhrazdil