Skip to content

Conversation

@vojtechszocs
Copy link
Contributor

@vojtechszocs vojtechszocs commented Aug 23, 2019

Depends on #2053, please review the second commit only.

This PR adds pre-composed ESLint configs representing common code archetypes:


  • react-typescript-prettier - applies to:

    • packages

  • node-typescript-prettier - applies to:

    • packages/console-plugin-sdk/src/codegen
    • packages/kubevirt-plugin/integration-tests

The import/no-extraneous-dependencies fix for monorepo (which is a common concern) is moved into the pre-composed configs.

This should (hopefully) lead to small and focused .eslintrc files.

/cc @christianvogt

FYI @spadgett @rhrazdil

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Aug 23, 2019
@christianvogt
Copy link
Contributor

Not sure why this depends on #2053.
Could you please remove the irrelevant commit.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 27, 2019
@vojtechszocs
Copy link
Contributor Author

Not sure why this depends on #2053.
Could you please remove the irrelevant commit.

Done, apologies for confusion.

These changes were supposed to be a follow-up to #2053 hence the original PR dependency.

@vojtechszocs
Copy link
Contributor Author

@christianvogt How do you feel about those pre-composed ESLint configs?

I'd expect node-typescript-prettier to be used on multiple sub-trees under packages

  • packages/console-plugin-sdk/src/codegen
  • packages/kubevirt-plugin/integration-tests
  • packages/dev-console/integration-tests
  • other places where code to be run by Node.js is kept

The packages tree uses react-typescript-prettier by default.

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vojtechszocs
Copy link
Contributor Author

/retest

1 similar comment
@vojtechszocs
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 56cdc95 into openshift:master Aug 28, 2019
@spadgett spadgett added this to the v4.2 milestone Aug 29, 2019
@logonoff logonoff deleted the improve-eslint-stuff branch September 25, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants