shared: PopoverStatus - support active icon and showing popover without header

[atiratree]

needed for #2452

[atiratree]

/retest

[vojtechszocs]

Can we extract this into PopoverStatusProps to avoid complex in-line types?

[vojtechszocs]

If hideHeader is true we'll be passing headerContent={false} to the Popover component.

I think it's more correct to omit headerContent instead of passing headerContent={false} but since the type is React.ReactNode I think this code is OK.

[vojtechszocs]

Can we use React.useCallback for function props, like onHide and onShow ?

[atiratree]

fixed

[vojtechszocs]

I think we should extract these memoized callbacks into separate variables.

Also, any function used within these callbacks should be treated as their dependency.

const [isActive, setActive] = React.useState(false);
const onHide = React.useCallback(() => setActive(false), [setActive]);

[atiratree]

fixed

[vojtechszocs]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment