Skip to content

[WIP] Remove orphaned react-lightweight-tooltip dependency and component #2415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhamilto wants to merge 2 commits into from
Closed

[WIP] Remove orphaned react-lightweight-tooltip dependency and component #2415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb160cf
Migrate PipelineBars tooltip to PF4
rhamilto Aug 20, 2019
f970eb3
Remove orphaned react-lightweight-tooltip dependency and component
rhamilto Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@
"react-dom": "16.8.6",
"react-helmet": "^5.2.1",
"react-jsonschema-form": "^1.0.4",
"react-lightweight-tooltip": "1.x",
"react-linkify": "^0.2.2",
"react-measure": "^2.2.6",
"react-modal": "3.x",
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/dev-console/src/components/pipelineruns/PipelineBars.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from 'react';
import { VictoryStack, VictoryBar } from 'victory';
import { Tooltip } from '@console/internal/components/utils/tooltip';
import { Tooltip } from '@patternfly/react-core';
import {
getTaskStatus,
runStatus,
Expand Down
6 changes: 0 additions & 6 deletions frontend/packages/dev-console/src/components/progressive-list/ProgressiveList.scss
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion frontend/packages/dev-console/src/components/progressive-list/ProgressiveList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import * as React from 'react';
import ProgressiveListFooter from './ProgressiveListFooter';
import ProgressiveListItem from './ProgressiveListItem';
import './ProgressiveList.scss';

export interface ProgressiveListProps {
visibleItems: string[];
Expand Down
9 changes: 3 additions & 6 deletions frontend/packages/dev-console/src/components/progressive-list/ProgressiveListFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as React from 'react';
import { Button } from '@patternfly/react-core';

export interface ProgressiveListFooterProps {
items: string[];
Expand Down Expand Up @@ -29,13 +30,9 @@ const ProgressiveListFooter: React.FC<ProgressiveListFooterProps> = ({
return (
<React.Fragment key={opt}>
{preText}
<button
className="btn btn-link odc-progressive-list__button"
type="button"
onClick={() => onShowItem(opt)}
>
<Button variant="link" isInline onClick={() => onShowItem(opt)}>
{opt}
</button>
</Button>
{postText}
</React.Fragment>
);
Expand Down
52 changes: 0 additions & 52 deletions frontend/public/components/utils/tooltip.tsx
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions frontend/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10239,10 +10239,6 @@ react-lifecycles-compat@^3.0.4:
version "3.0.4"
resolved "https://registry.yarnpkg.com/react-lifecycles-compat/-/react-lifecycles-compat-3.0.4.tgz#4f1a273afdfc8f3488a8c516bfda78f872352362"

[email protected]:
version "1.0.0"
resolved "https://registry.yarnpkg.com/react-lightweight-tooltip/-/react-lightweight-tooltip-1.0.0.tgz#1fb96831b88de21a4d73d02148aae3d8d0aea9bc"

react-linkify@^0.2.2:
version "0.2.2"
resolved "https://registry.yarnpkg.com/react-linkify/-/react-linkify-0.2.2.tgz#55b99b1cc7244446a0f9bdebbe13b2c30f789e65"
Expand Down