[metal3] add data-test-id for dashboard components

[dantrainor]

No description provided.

[openshift-ci-robot]

Hi @dantrainor. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dantrainor
To complete the pull request process, please assign jtomasek
You can assign the PR to them by writing /assign @jtomasek in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/packages/metal3-plugin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dantrainor]

Amended the commit to remove frontend/public/components/dashboard/inventory-card/inventory-item.tsx, it was erroneously included; it is instead part of #2287 , though this will depend on #2287

[dantrainor]

/assign @jtomasek

[spadgett]

Please add the attributes in the same PR as the tests so we can see how they will be used.

[dantrainor]

Please add the attributes in the same PR as the tests so we can see how they will be used.

Just to clarify, are you suggesting that #1886 change to use the attributes named in this PR, or merge these changes (and the ones from #2287) into #1886 ?

[spadgett]

Please add the attributes in the same PR as the tests so we can see how they will be used.

Just to clarify, are you suggesting that #1886 change to use the attributes named in this PR, or merge these changes (and the ones from #2287) into #1886 ?

I'm suggesting to merge the changes so it's all one PR. That makes it easier to understand and review.

[dantrainor]

Please add the attributes in the same PR as the tests so we can see how they will be used.

Just to clarify, are you suggesting that #1886 change to use the attributes named in this PR, or merge these changes (and the ones from #2287) into #1886 ?

I'm suggesting to merge the changes so it's all one PR. That makes it easier to understand and review.

Understood. Per @honza 's comment on #2287 this was split to ease review burden.

[jtomasek]

+1 to adding this to the tests PR #1886 so the usage of the ids is clear

[dantrainor]

This is going to become part of #1886