Skip to content

Add VM Template test cases for Kubevirt plugin #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 7, 2019
Merged

Add VM Template test cases for Kubevirt plugin #2066

openshift-merge-robot merged 1 commit into from
Oct 7, 2019

Conversation

@yaacov
Copy link
Member

@yaacov yaacov commented Jul 17, 2019 •
edited
Loading

Initial integration tests for vmtemplates

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 17, 2019
@yaacov
Copy link
Member Author

yaacov commented Jul 17, 2019

@rhrazdil @mareklibra @vojtechszocs @suomiy @rawagner please review.

The commit specific for this PR is: ef1f670

@yaacov yaacov changed the title Kubevirt vmtemplate integration tests [WIP] Kubevirt vmtemplate integration tests Jul 17, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2019
@yaacov
Copy link
Member Author

yaacov commented Jul 17, 2019

/test e2e-aws
/test e2e-aws-console-olm

@yaacov yaacov force-pushed the kubevirt-vmtemplate-integration-tests branch from 1f2b244 to ecac15b Compare July 18, 2019 11:23
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2019
@yaacov yaacov force-pushed the kubevirt-vmtemplate-integration-tests branch from 13c4bd0 to 17628c4 Compare July 18, 2019 11:57
@yaacov
Copy link
Member Author

yaacov commented Jul 18, 2019

@rhrazdil update :-) , re-based on #2053 for the common utils and models.

rhrazdil
rhrazdil suggested changes Jul 18, 2019
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/models/template.ts Outdated
Copy link

@rhrazdil rhrazdil Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better to set globally, we inherently need to use await in loops.

frontend/packages/kubevirt-plugin/integration-tests/tests/models/template.ts Outdated
Copy link

@rhrazdil rhrazdil Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this, I have disabled no-console check as well, but it's probably not necessary to write the error to console since we throw an exception right after....

frontend/packages/kubevirt-plugin/integration-tests/tests/models/template.ts Outdated
Copy link

@rhrazdil rhrazdil Jul 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to utils/types.ts?

Copy link
Member Author

@yaacov yaacov Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 moved

rhrazdil
rhrazdil reviewed Jul 19, 2019
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/models/template.ts Outdated
Copy link

@rhrazdil rhrazdil Jul 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind: 'templates' needs to be changed to kind: 'vmtemplates'

Copy link
Member Author

@yaacov yaacov Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@yaacov yaacov force-pushed the kubevirt-vmtemplate-integration-tests branch 6 times, most recently from 930b3bb to 8ab1bcd Compare July 22, 2019 10:12
@yaacov
Copy link
Member Author

yaacov commented Jul 22, 2019

/retest

3 similar comments
@yaacov
Copy link
Member Author

yaacov commented Jul 22, 2019

/retest

@yaacov
Copy link
Member Author

yaacov commented Jul 22, 2019

/retest

@yaacov
Copy link
Member Author

yaacov commented Jul 22, 2019

/retest

@yaacov yaacov force-pushed the kubevirt-vmtemplate-integration-tests branch from a31ca1a to e80972d Compare July 23, 2019 06:29
@yaacov
Copy link
Member Author

yaacov commented Jul 23, 2019

/test e2e-aws

@yaacov
Copy link
Member Author

yaacov commented Jul 23, 2019

/retest

@yaacov yaacov force-pushed the kubevirt-vmtemplate-integration-tests branch from bb5c729 to 87c7894 Compare July 24, 2019 09:42
@yaacov yaacov changed the title [WIP] Kubevirt vmtemplate integration tests [WIP] Add VM Template Wizard test cases for Kubevirt plugin Jul 24, 2019
@yaacov yaacov force-pushed the kubevirt-vmtemplate-integration-tests branch from 751eb4b to 43ba37d Compare July 24, 2019 10:54
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2019
@yaacov yaacov force-pushed the kubevirt-vmtemplate-integration-tests branch 4 times, most recently from bd29adb to 581537b Compare October 7, 2019 08:17
@yaacov
Copy link
Member Author

yaacov commented Oct 7, 2019

/test e2e-aws-console

@yaacov yaacov force-pushed the kubevirt-vmtemplate-integration-tests branch from 581537b to b0fda6f Compare October 7, 2019 10:15
@yaacov
Copy link
Member Author

yaacov commented Oct 7, 2019

@rhrazdil @suomiy hi, needed rebase ... , needs re-review, and re-lgtm :

Changed after rebase ( apart from the rebase itself ) is removing the tests that a VM is actually created, in current version we have a similar check, and we do not need the one intruduced by this PR.

@rhrazdil
Copy link

rhrazdil commented Oct 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil, suomiy, vojtechszocs, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Oct 7, 2019

LGTM on change diff.

@openshift-merge-robot openshift-merge-robot merged commit 5ad4234 into openshift:master Oct 7, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminapetersen benjaminapetersen Awaiting requested review from benjaminapetersen

@christianvogt christianvogt Awaiting requested review from christianvogt

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

1 more reviewer

@atiratree atiratree atiratree approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vojtechszocs vojtechszocs

@rhrazdil rhrazdil

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

8 participants

@yaacov @atiratree @vojtechszocs @openshift-bot @rhrazdil @openshift-ci-robot @spadgett @openshift-merge-robot