-
Notifications
You must be signed in to change notification settings - Fork 667
Add auth file just for login purpose #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gouyang The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @alecmerdler @TheRealJon |
|
I don't know if this is what we want. We created the login scenario to more fully exercise the login workflow. This simple auth test is more or less the same as what we moved away from. @spadgett what do you think? |
|
@TheRealJon @spadgett As kubevirt tests are going to move here, the current login scenario which has lots of login test seems no necessary for it, so I'm trying to create a simple auth scenario for all tests. |
Fixes #2015 Signed-off-by: Guohua Ouyang <[email protected]>
|
|
||
| export const login = async(providerName: string, username: string, password: string) => { | ||
| if (providerName) { | ||
| if (await $('a.idp').isPresent()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break our current login test. If the IDP that we create is still in flight when the login scenario runs, this condition will be false, meaning the IDP selection will be skipped, and we will attempt to login using test user credentials against the kubeadmin idp.
The login scenario has a single test suite Let's wait for @spadgett inputs. |
Fixes #2015
Signed-off-by: Guohua Ouyang [email protected]