Skip to content

Conversation

@gouyang
Copy link
Contributor

@gouyang gouyang commented Jul 12, 2019

Fixes #2015

Signed-off-by: Guohua Ouyang [email protected]

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gouyang
To complete the pull request process, please assign alecmerdler
You can assign the PR to them by writing /assign @alecmerdler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2019
@spadgett
Copy link
Member

/assign @alecmerdler @TheRealJon

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2019
@TheRealJon
Copy link
Member

I don't know if this is what we want. We created the login scenario to more fully exercise the login workflow. This simple auth test is more or less the same as what we moved away from. @spadgett what do you think?

@gouyang
Copy link
Contributor Author

gouyang commented Jul 30, 2019

@TheRealJon @spadgett As kubevirt tests are going to move here, the current login scenario which has lots of login test seems no necessary for it, so I'm trying to create a simple auth scenario for all tests.

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2019
Fixes #2015

Signed-off-by: Guohua Ouyang <[email protected]>
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2019

export const login = async(providerName: string, username: string, password: string) => {
if (providerName) {
if (await $('a.idp').isPresent()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break our current login test. If the IDP that we create is still in flight when the login scenario runs, this condition will be false, meaning the IDP selection will be skipped, and we will attempt to login using test user credentials against the kubeadmin idp.

@TheRealJon
Copy link
Member

@gouyang I think we'll need some input from @spadgett on this. The changes to protractor.conf.ts remove our existing login test from all of the suites, which I'm pretty sure isn't what we want.

@gouyang
Copy link
Contributor Author

gouyang commented Jul 30, 2019

@gouyang I think we'll need some input from @spadgett on this. The changes to protractor.conf.ts remove our existing login test from all of the suites, which I'm pretty sure isn't what we want.

The login scenario has a single test suite login, so I think we don't need to worry about it.

Let's wait for @spadgett inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'login.scenario.ts' is used in many test suite when kubeadmin password is set

6 participants