Skip to content

Add Azure Red Hat OpenShift branding option #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 9, 2019
Merged

Add Azure Red Hat OpenShift branding option #1233

openshift-merge-robot merged 1 commit into from
Mar 9, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Feb 26, 2019

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2019
@spadgett
Copy link
Member

spadgett commented Feb 26, 2019

We'll need to update openshift/api too. cc @benjaminapetersen

https://github.com/openshift/api/blob/master/operator/v1/types_console.go#L41-L55

@spadgett
Copy link
Member

spadgett commented Feb 26, 2019

Also openshift/console-operator#152

cc @zherman0

@zherman0
Copy link
Member

zherman0 commented Feb 26, 2019

@spadgett - azure has been added to console-operator

@benjaminapetersen benjaminapetersen mentioned this pull request Feb 26, 2019
Merged
1 task
@rhamilto
Copy link
Member Author

rhamilto commented Feb 28, 2019

Rebased. @spadgett, PTAL.

@spadgett spadgett added this to the v4.0 milestone Mar 7, 2019
spadgett
spadgett approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit f33ec92 into openshift:master Mar 9, 2019
@jim-minter
Copy link

jim-minter commented Mar 9, 2019

thanks @rhamilto @spadgett !

@rhamilto rhamilto deleted the azure-branding branch March 11, 2019 12:37
@spadgett spadgett modified the milestones: v4.0, v4.1 Apr 16, 2019
@kaczyns kaczyns mentioned this pull request Oct 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels

lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.1

Development

Successfully merging this pull request may close these issues.

6 participants

@rhamilto @spadgett @zherman0 @jim-minter @openshift-ci-robot @openshift-merge-robot