Skip to content

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Feb 1, 2019

cluster.k8s.io/v1alpha1 -> machine.openshift.io/v1beta1

See openshift/installer#1175

cc @jwforres @derekwaynecarr

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 1, 2019
@enxebre
Copy link
Member

enxebre commented Feb 4, 2019

looks good to me

@spadgett spadgett changed the title [WIP] Update machine API group and version Update machine API group and version Feb 7, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2019
@spadgett
Copy link
Member Author

spadgett commented Feb 7, 2019

/assign @TheRealJon

@spadgett
Copy link
Member Author

spadgett commented Feb 7, 2019

The installer changes have merged. This should be ready.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2019
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member Author

spadgett commented Feb 7, 2019

/test frontend

@spadgett
Copy link
Member Author

spadgett commented Feb 7, 2019

/retest

2 similar comments
@spadgett
Copy link
Member Author

spadgett commented Feb 8, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Feb 8, 2019

/retest

@spadgett
Copy link
Member Author

spadgett commented Feb 8, 2019

flake https://jira.coreos.com/browse/CONSOLE-1266

/retest

@spadgett
Copy link
Member Author

spadgett commented Feb 8, 2019

/retest

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Feb 8, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit b9d117e into openshift:master Feb 8, 2019
@spadgett spadgett deleted the machine-api-group branch February 8, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants