CONSOLE-2892: Allow dynamic plugins to proxy to services on the cluster by jhadvig · Pull Request #10215 · openshift/console

jhadvig · 2021-10-12T11:54:24Z

Console changes for story https://issues.redhat.com/browse/CONSOLE-2892

Adding --plugin-proxy flag which will contain all the various service types (but for now just just k8s Services) that console backend should proxy to.
PR is working in addition to console-operator changes in openshift/console-operator#603

/assign @spadgett @TheRealJon

spadgett

Thanks @jhadvig

spadgett · 2021-10-13T17:51:07Z

We should add some details to the dynamic plugins README. We need to let developers know how to set up a proxy when running bridge locally.

jhadvig · 2021-10-14T06:14:40Z

@spadgett comments addressed. PTAL

jhadvig · 2021-10-14T06:15:37Z

Borrowed this part from the enhancement doc since I think it would be useful for the dev/user as well

jhadvig · 2021-10-25T10:10:33Z

@spadgett I've added proxy service to the console-demo-plugin which is pointing to the thanos-querier service in the openshift-monitoring. Also I've extended the dynamic-demo-plugin's console-extensions.json with /test-proxy-service route that will use the proxy service to query Thanos for list of Rules.

Screen:

Please let me know if anything else is needed.

jhadvig · 2021-10-26T08:12:02Z

@spadgett thanks for review, I've addressed your comments. PTAL

jhadvig · 2021-11-01T19:25:11Z

PR is ready for final review.

QE Approver:
/assign @yapei

Docs Approver:
/assign @opayne1

PX Approver:
/assign @RickJWagner

Console Approver:
/assign @spadgett

RickJWagner · 2021-11-02T13:54:24Z

/label px-approved

opayne1 · 2021-11-02T16:18:46Z

/label docs-approved

spadgett

Looks good overall, thanks @jhadvig

yapei · 2021-11-04T10:56:35Z

verified the changes locally and works

./bin/bridge --plugin-proxy='{"services":[{"endpoint":"http://localhost:8080","consoleAPIPath":"/api/proxy/namespace/openshift-monitoring/service/thanos-querier:9091/"}]}' -plugins console-demo-plugin=http://localhost:9001

/label qe-approved

jhadvig · 2021-11-04T12:32:54Z

@spadgett I've addressed your comments in a additional commit. PTAL

spadgett

/lgtm

jhadvig · 2021-11-04T17:50:37Z

We need to get openshift/client-go#199 in and update the go deps. accordingly.
/hold

jhadvig · 2021-11-04T18:23:28Z

GO deps have been updated. @spadgett please could you retag the PR. Thank you

/hold cancel

spadgett

/lgtm

openshift-ci · 2021-11-04T18:33:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jhadvig,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-11-04T20:16:21Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2021

openshift-ci Bot requested review from florkbr and spadgett October 12, 2021 11:54

openshift-ci Bot added component/backend Related to backend kind/dependency-change Categorizes issue or PR as related to changing dependencies approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2021

jhadvig force-pushed the CONSOLE-2892 branch 2 times, most recently from 3879cbe to 607d2e7 Compare October 12, 2021 16:26

jhadvig changed the title ~~[WIP] CONSOLE-2892: Allow dynamic plugins to proxy to services on the cluster~~ CONSOLE-2892: Allow dynamic plugins to proxy to services on the cluster Oct 12, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2021

jhadvig commented Oct 12, 2021

View reviewed changes

Comment thread pkg/serverconfig/types.go Outdated

spadgett reviewed Oct 13, 2021

View reviewed changes

Comment thread pkg/server/server.go Outdated

Comment thread pkg/plugins/handlers.go Outdated

Comment thread pkg/plugins/handlers.go Outdated

Comment thread pkg/serverconfig/types.go Outdated

jhadvig force-pushed the CONSOLE-2892 branch from 607d2e7 to 2cc0b8f Compare October 14, 2021 06:14

jhadvig commented Oct 14, 2021

View reviewed changes

jhadvig force-pushed the CONSOLE-2892 branch from bdf9262 to ce15a96 Compare October 25, 2021 10:04

spadgett reviewed Oct 25, 2021

View reviewed changes

jhadvig force-pushed the CONSOLE-2892 branch from ce15a96 to a41029f Compare October 26, 2021 08:10

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2021

jhadvig force-pushed the CONSOLE-2892 branch from a41029f to 28a6aeb Compare November 1, 2021 15:30

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2021

openshift-ci Bot assigned opayne1, RickJWagner, spadgett and yapei Nov 1, 2021

openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Nov 2, 2021

openshift-ci Bot added the docs-approved Signifies that Docs has signed off on this PR label Nov 2, 2021

spadgett reviewed Nov 3, 2021

View reviewed changes

Comment thread dynamic-demo-plugin/README.md Outdated

Comment thread dynamic-demo-plugin/src/components/ProxyService.tsx Outdated

Comment thread dynamic-demo-plugin/src/components/ProxyService.tsx Outdated

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Nov 4, 2021

spadgett approved these changes Nov 4, 2021

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021

CONSOLE-2892: Allow dynamic plugins to proxy to services on the cluster

430ce0d

jhadvig force-pushed the CONSOLE-2892 branch from 5c91baf to 430ce0d Compare November 4, 2021 18:22

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021

spadgett approved these changes Nov 4, 2021

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2021

openshift-merge-robot merged commit 63281ba into openshift:master Nov 5, 2021

spadgett added this to the v4.10 milestone Dec 8, 2021

Conversation

jhadvig commented Oct 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spadgett commented Oct 13, 2021

Uh oh!

jhadvig commented Oct 14, 2021

Uh oh!

jhadvig Oct 14, 2021

Choose a reason for hiding this comment

Uh oh!

jhadvig commented Oct 25, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhadvig commented Oct 26, 2021

Uh oh!

jhadvig commented Nov 1, 2021

Uh oh!

RickJWagner commented Nov 2, 2021

Uh oh!

opayne1 commented Nov 2, 2021

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yapei commented Nov 4, 2021

Uh oh!

jhadvig commented Nov 4, 2021

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

jhadvig commented Nov 4, 2021

Uh oh!

jhadvig commented Nov 4, 2021

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Nov 4, 2021

Uh oh!

openshift-bot commented Nov 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jhadvig commented Oct 12, 2021 •

edited

Loading