Skip to content

OCPEDGE-1345: feat: add arbiter node support for HA #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 22, 2025
Merged

OCPEDGE-1345: feat: add arbiter node support for HA #939

openshift-merge-bot merged 1 commit into from
Jan 22, 2025

Conversation

@eggfoobar
Copy link
Contributor

@eggfoobar eggfoobar commented Nov 5, 2024 •
edited
Loading

Per EP: openshift/enhancements#1674

This PR bumps to the latest ocp/api to pull in the new control plane topology defined in the Arbiter EP. The HighlyAvailableArbiter is a new control plane topology that allows for 2 regular sized master nodes and 1 smaller arbiter node as part of the control plane, this PR adds the check so that HA is still respected when the control plane topology is set to HighlyAvailableArbiter

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@openshift-ci openshift-ci bot requested review from jhadvig and spadgett November 5, 2024 17:55
@eggfoobar eggfoobar force-pushed the arbiter-node-support branch from 94baddf to 8f0a47f Compare November 5, 2024 18:51
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2024
@eggfoobar eggfoobar force-pushed the arbiter-node-support branch from 8f0a47f to 9e6bd74 Compare November 18, 2024 01:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2024
@eggfoobar eggfoobar force-pushed the arbiter-node-support branch from 9e6bd74 to 3f2b2ab Compare November 18, 2024 02:26
@eggfoobar eggfoobar changed the title WIP: feat: add arbiter node support for HA WIP: OCPEDGE-1345: feat: add arbiter node support for HA Nov 18, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 18, 2024 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1345 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar eggfoobar force-pushed the arbiter-node-support branch from 3f2b2ab to 415c0cc Compare December 11, 2024 19:58
@eggfoobar
feat: add arbiter node support for HA
fee0db5 
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar force-pushed the arbiter-node-support branch from 415c0cc to fee0db5 Compare December 11, 2024 20:02
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2024 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1345 which is a valid jira issue.

Details

In response to this:

Per EP: openshift/enhancements#1674

This PR bumps to the latest ocp/api to pull in the new control plane topology defined in the Arbiter EP. The HighlyAvailableArbiter is a new control plane topology that allows for 2 regular sized master nodes and 1 smaller arbiter node as part of the control plane, this PR adds the check so that HA is still respected when the control plane topology is set to HighlyAvailableArbiter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar eggfoobar changed the title WIP: OCPEDGE-1345: feat: add arbiter node support for HA OCPEDGE-1345: feat: add arbiter node support for HA Dec 11, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2024
jhadvig
jhadvig approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Dec 13, 2024

/retest-required

3 similar comments
@eggfoobar
Copy link
Contributor Author

eggfoobar commented Dec 14, 2024

/retest-required

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Dec 17, 2024

/retest-required

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Dec 18, 2024

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024 •
edited
Loading

@eggfoobar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn fee0db5 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Dec 25, 2024

/retest-required

@sr1kar99
Copy link

sr1kar99 commented Jan 22, 2025

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jan 22, 2025
@Neilhamza
Copy link

Neilhamza commented Jan 22, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 22, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2025 •
edited by openshift-ci bot
Loading

@eggfoobar: This pull request references OCPEDGE-1345 which is a valid jira issue.

Details

In response to this:

Per EP: openshift/enhancements#1674

This PR bumps to the latest ocp/api to pull in the new control plane topology defined in the Arbiter EP. The HighlyAvailableArbiter is a new control plane topology that allows for 2 regular sized master nodes and 1 smaller arbiter node as part of the control plane, this PR adds the check so that HA is still respected when the control plane topology is set to HighlyAvailableArbiter

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar
Copy link
Contributor Author

eggfoobar commented Jan 22, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 22, 2025
@sferich888
Copy link

sferich888 commented Jan 22, 2025

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 22, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit c9beaf1 into openshift:master Jan 22, 2025
9 of 10 checks passed
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console-operator
This PR has been included in build openshift-enterprise-console-operator-container-v4.19.0-202501221639.p0.gc9beaf1.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@eggfoobar @openshift-ci-robot @sr1kar99 @Neilhamza @sferich888 @openshift-bot @jhadvig @openshift-merge-robot