Skip to content

[release-4.16] OCPBUGS-33788: Tolerate the absence of ingress capability on HyperShift clusters #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 3 commits into from
Jul 3, 2024
Merged

[release-4.16] OCPBUGS-33788: Tolerate the absence of ingress capability on HyperShift clusters #910

openshift-merge-bot merged 3 commits into from
Jul 3, 2024

Conversation

@alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Jun 7, 2024

Backport of #886.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 7, 2024

@alebedev87: This pull request references Jira Issue OCPBUGS-33788, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-33787 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of #886.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett June 7, 2024 07:53
@alebedev87 alebedev87 force-pushed the tolerate-ingress-absence-4-16 branch from efe0afc to d51c66c Compare June 7, 2024 08:25
@alebedev87 alebedev87 changed the title OCPBUGS-33788: Tolerate the absence of ingress capability on HyperShift clusters [release-4.16] OCPBUGS-33788: Tolerate the absence of ingress capability on HyperShift clusters Jun 7, 2024
@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 7, 2024

/retest

2 similar comments
@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 7, 2024

/retest

@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 10, 2024

/retest

@alebedev87 alebedev87 force-pushed the tolerate-ingress-absence-4-16 branch from d51c66c to 7a5bced Compare June 10, 2024 11:12
@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 10, 2024

/retest

2 similar comments
@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 10, 2024

/retest

@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 11, 2024

/retest

@melvinjoseph86
Copy link

melvinjoseph86 commented Jun 26, 2024

/test e2e-aws-console

1 similar comment
@melvinjoseph86
Copy link

melvinjoseph86 commented Jun 26, 2024

/test e2e-aws-console

@alebedev87 alebedev87 force-pushed the tolerate-ingress-absence-4-16 branch from 7a5bced to 6f483ab Compare June 28, 2024 08:01
@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 28, 2024 •
edited
Loading

Add cluster wide trusted CA bundle to operator commit added.

@alebedev87
Copy link
Contributor Author

alebedev87 commented Jun 28, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 28, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 28, 2024

@alebedev87: This pull request references Jira Issue OCPBUGS-33788, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-33787 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-33787 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from melvinjoseph86 June 28, 2024 08:02
@melvinjoseph86
Copy link

melvinjoseph86 commented Jun 30, 2024

/test e2e-azure-ovn-upgrade

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 2, 2024
Merged
@alebedev87 alebedev87 force-pushed the tolerate-ingress-absence-4-16 branch from 6f483ab to ea96eed Compare July 2, 2024 20:38
alebedev87 added 3 commits July 2, 2024 22:41
@alebedev87
OCPBUGS-33787: Bump openshift/api to get ingress fields from console …
110ee15 
…operator API
@alebedev87
OCPBUGS-33787: Tolerate the absence of ingress capability on HyperShi…
89ab587 
…ft clusters

- Implement alternative ingress fields from the console operator config API
- Skip component route customizations if ingress capability is disabled
- Use NodePort type for console and downloads services if ingress capability is disabled
- Add document to describe how to implement alternative ingress on ROSA
@alebedev87
OCPBUGS-33787: Add cluster wide trusted CA bundle to operator
69e23dd 
The alternative ingress can be provided via the console config API.
This commit ensures that health checks to the alternative ingress
pass TLS certificate validation even when the TLS certificate has an unknown CA.
@alebedev87 alebedev87 force-pushed the tolerate-ingress-absence-4-16 branch from ea96eed to 69e23dd Compare July 2, 2024 20:42
@melvinjoseph86
Copy link

melvinjoseph86 commented Jul 3, 2024

/test e2e-aws-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jhadvig
jhadvig approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jhadvig
Copy link
Member

jhadvig commented Jul 3, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 3, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@melvinjoseph86
Copy link

melvinjoseph86 commented Jul 3, 2024

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2024

@melvinjoseph86: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sanketpathak
Copy link

sanketpathak commented Jul 3, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 70c05de into openshift:release-4.16 Jul 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 3, 2024

@alebedev87: Jira Issue OCPBUGS-33788: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33788 has been moved to the MODIFIED state.

Details

In response to this:

Backport of #886.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 3, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-operator-container-v4.16.0-202407031636.p0.g70c05de.assembly.stream.el9 for distgit openshift-enterprise-console-operator.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Jul 4, 2024

Fix included in accepted release 4.16.0-0.nightly-2024-07-04-015518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@melvinjoseph86 melvinjoseph86 Awaiting requested review from melvinjoseph86

Assignees

@jhadvig jhadvig

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@alebedev87 @openshift-ci-robot @melvinjoseph86 @jhadvig @sanketpathak @openshift-bot @openshift-merge-robot @yanpzhan @yapei