Skip to content

Implement multicluster tech preview#630

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
TheRealJon:multicluster-feature
Jan 27, 2022
Merged

Implement multicluster tech preview#630
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
TheRealJon:multicluster-feature

Conversation

@TheRealJon
Copy link
Copy Markdown
Member

@TheRealJon TheRealJon commented Jan 20, 2022

  • Add managed cluster controller that uses the ACM ManagedCluster, ManagedClusterView, and ManagedClusterAction APIs to aggregate managed cluster data into a config file that can be consumed by the console backend
  • Update console deployment sync with new volumes and volume mounts for managed cluster related configmaps.
  • Add managed cluster config, API server CA bundle, and oauth server ConfigMaps to subresources
  • Add ManagedClusterView subresources for oauth clients and oauth server certs
  • Add ManagedClusterAction subresource for oauth client creation
  • Update informer event filter utils
  • Add github.com/open-cluster-management/api dependency

@openshift-ci openshift-ci Bot requested review from jhadvig and spadgett January 20, 2022 18:57
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@TheRealJon TheRealJon mentioned this pull request Jan 20, 2022
Closed
@TheRealJon
Implement multicluster tech preview
23f7831 
- Add managed cluster controller that uses the ACM ManagedCluster, ManagedClusterView, and ManagedClusterAction APIs to aggregate managed cluster data into a config file that can be consumed by the console backend
- Update console deployment sync with new volumes and volume mounts for managed cluster related configmaps.
- Add managed cluster config, API server CA bundle, and oauth server ConfigMaps to subresources
- Add ManagedClusterView subresources for oauth clients and oauth server certs
- Add ManagedClusterAction subresource for oauth client creation
- Update informer event filter utils
- Add github.com/open-cluster-management/api dependency
@TheRealJon TheRealJon force-pushed the multicluster-feature branch from ee963d2 to 23f7831 Compare January 20, 2022 20:51
@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 21, 2022

/retest

1 similar comment
@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 21, 2022

/retest

@TheRealJon TheRealJon requested a review from florkbr January 21, 2022 14:44
@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 24, 2022

QE Approver
/assign @yapei

Docs Approver:
/assign @opayne1

PX Approver:
/assign @RickJWagner

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 24, 2022

/retest

@opayne1
Copy link
Copy Markdown
Contributor

opayne1 commented Jan 24, 2022

/label docs-approved

@openshift-ci openshift-ci Bot added the docs-approved Signifies that Docs has signed off on this PR label Jan 24, 2022
@RickJWagner
Copy link
Copy Markdown

RickJWagner commented Jan 24, 2022

/label px-approved

@RickJWagner RickJWagner removed their assignment Jan 24, 2022
@openshift-ci openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 24, 2022
@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 24, 2022

/retest

2 similar comments
@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 25, 2022

/retest

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 25, 2022

/retest

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Jan 25, 2022

So the metrics test keeps failing:

=== RUN   TestMetricsEndpoint
    metrics_test.go:31: waiting for setup to reach settled state...
    metrics_test.go:171: route for metrics: https://metrics-openshift-console-operator.apps.ci-op-nigr9ny4-4e531.origin-ci-int-aws.dev.rhcloud.com/metrics
    metrics_test.go:177: route to /metrics: (https://metrics-openshift-console-operator.apps.ci-op-nigr9ny4-4e531.origin-ci-int-aws.dev.rhcloud.com/metrics)
    metrics_test.go:59: fetching metrics url.... https://metrics-openshift-console-operator.apps.ci-op-nigr9ny4-4e531.origin-ci-int-aws.dev.rhcloud.com/metrics
    metrics_test.go:61: fetching /metrics data...
    metrics_test.go:98: http error: 503 Service Unavailable

wondering why that might be, flake?

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Jan 25, 2022

/retest

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 25, 2022

/retest

The "TestMetricsEndpoint" test case seems to be flaking a lot across multiple PRs, so I don't think it's due to any changes that are being introduced here.

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Jan 26, 2022

/test e2e-aws-operator

@yapei
Copy link
Copy Markdown
Contributor

yapei commented Jan 26, 2022

tested the changes following instructions https://gist.github.com/TheRealJon/921905a74329891e1f2153a2d57aa44d , working as expected
/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jan 26, 2022
jhadvig
jhadvig approved these changes Jan 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jhadvig jhadvig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job @TheRealJon 👍

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Jan 26, 2022

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 26, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Jan 26, 2022

/retest

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
@TheRealJon TheRealJon force-pushed the multicluster-feature branch from 846f5e4 to 74c0a97 Compare January 26, 2022 20:18
@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 26, 2022

/retest-required

@TheRealJon
Copy link
Copy Markdown
Member Author

TheRealJon commented Jan 27, 2022

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 27, 2022

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jhadvig
Copy link
Copy Markdown
Member

jhadvig commented Jan 27, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c92e214 into openshift:master Jan 27, 2022
@TheRealJon TheRealJon deleted the multicluster-feature branch January 27, 2022 15:41
@florkbr florkbr mentioned this pull request Mar 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

@florkbr florkbr Awaiting requested review from florkbr

Assignees

@jhadvig jhadvig

@yapei yapei

@opayne1 opayne1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@TheRealJon @opayne1 @RickJWagner @jhadvig @yapei @openshift-bot @openshift-merge-robot