Skip to content

CONSOLE-2757: Bump github.com/openshift/api #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 16, 2021
Merged

CONSOLE-2757: Bump github.com/openshift/api #506

openshift-merge-robot merged 1 commit into from
Feb 16, 2021

Conversation

@jhadvig
Copy link
Member

@jhadvig jhadvig commented Feb 9, 2021

To pickup changes from openshift/api#827

/assign @spadgett

@spadgett spadgett changed the title Bump github.com/openshift/api CONSOLE-2757: Bump github.com/openshift/api Feb 9, 2021
spadgett
spadgett approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals
/assign @yapei @sferich888 @ahardin-rh

@yapei This is needed for the single node story, but it only updates the openshift/api dependency. So for now we just need to check for regressions. Thank you!

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@jhadvig
Copy link
Member Author

jhadvig commented Feb 9, 2021

Looks like flaky tests
/retest

1 similar comment
@jhadvig
Copy link
Member Author

jhadvig commented Feb 9, 2021

Looks like flaky tests
/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2021
@ahardin-rh
Copy link

ahardin-rh commented Feb 12, 2021

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Feb 12, 2021
@yapei
Copy link
Contributor

yapei commented Feb 15, 2021

QE did some regression testing and no issues found.

@yapei
Copy link
Contributor

yapei commented Feb 15, 2021

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Feb 15, 2021
spadgett
spadgett approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2021
@sferich888
Copy link

sferich888 commented Feb 15, 2021

As part of this work we also need to work within https://issues.redhat.com/browse/CONSOLE-2759 to provide enablement for the support / field teams.

@sferich888
Copy link

sferich888 commented Feb 15, 2021

/unassign @sferich888
/label px-approved

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Feb 15, 2021
@jhadvig
Copy link
Member Author

jhadvig commented Feb 16, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 16, 2021
@jhadvig
Copy link
Member Author

jhadvig commented Feb 16, 2021

@spadgett I've accidentally pushed into this this branch. Could you please re-tag.
Sorry & thanks :)

spadgett
spadgett approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

spadgett commented Feb 16, 2021

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6e1cbc8 into openshift:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@bparees bparees Awaiting requested review from bparees

Assignees

@spadgett spadgett

@yapei yapei

@ahardin-rh ahardin-rh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jhadvig @ahardin-rh @yapei @sferich888 @spadgett @openshift-ci-robot @openshift-merge-robot