Bug 1872375: Add RedHat Helm chart repository as default repo in OCP payload #458
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| apiVersion: helm.openshift.io/v1beta1 | ||
| kind: HelmChartRepository | ||
| metadata: | ||
| annotations: | ||
| "release.openshift.io/create-only": 'true' | ||
| name: redhat-helm-repo | ||
| spec: | ||
| name: Red Hat Helm Charts | ||
| connectionConfig: | ||
| url: https://redhat-developer.github.io/redhat-helm-charts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,3 +54,18 @@ subjects: | |
| - kind: ServiceAccount | ||
| name: console | ||
| namespace: openshift-console | ||
| --- | ||
| kind: ClusterRoleBinding | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| metadata: | ||
| annotations: | ||
| "release.openshift.io/create-only": 'true' | ||
| name: helm-chartrepos-view | ||
| subjects: | ||
| - kind: Group | ||
| apiGroup: rbac.authorization.k8s.io | ||
| name: 'system:authenticated' | ||
|
Member
There was a problem hiding this comment. I believe you're need a PR like openshift/origin#23975 to get this to pass CI. |
||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: helm-chartrepos-viewer | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, all authenticated users should be allowed to 'read' helm chart repositories. That'll naturally drive the content in the developer catalog.
Any advanced configuration needs to be done by the admin outside the scope of console.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't
watchaction be needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, because the operator does not watch for changes. The permissions are needed for console
/api/helm/charts/index.yamlendpoiint - it retrieves the list of allHelmChartRepositoryCRs from the cluster, and use them to retrieve individualindex.yamlfiles that get combined at the end.