Skip to content

Update CRD manifests due to the Href field validation update#321

Closed
jhadvig wants to merge 1 commit intoopenshift:masterfrom
jhadvig:update-crds
Closed

Update CRD manifests due to the Href field validation update#321
jhadvig wants to merge 1 commit intoopenshift:masterfrom
jhadvig:update-crds

Conversation

@jhadvig
Copy link
Copy Markdown
Member

@jhadvig jhadvig commented Oct 22, 2019

Copied the validation change change. Although not sure why there are so many changes.

/assign @benjaminapetersen

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhadvig
To complete the pull request process, please assign benjaminapetersen
You can assign the PR to them by writing /assign @benjaminapetersen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@jhadvig: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console 2d0420b link /test e2e-aws-console

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benjaminapetersen
Copy link
Copy Markdown
Contributor

I think we probably want this one instead:
#316

Perhaps with a fresh bump deps.

@benjaminapetersen
Copy link
Copy Markdown
Contributor

/close

Lets consume these now from openshift/api via #321

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@benjaminapetersen: Closed this PR.

Details

In response to this:

/close

Lets consume these now from openshift/api via #321

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants