Skip to content

Expose /metrics endpoint for monitoring#313

Closed
benjaminapetersen wants to merge 1 commit intoopenshift:release-4.1from
benjaminapetersen:backport/4.1/metrics
Closed

Expose /metrics endpoint for monitoring#313
benjaminapetersen wants to merge 1 commit intoopenshift:release-4.1from
benjaminapetersen:backport/4.1/metrics

Conversation

@benjaminapetersen
Copy link
Copy Markdown
Contributor

This is a cherry-pick (with resolutions) of #270 which exposes metrics, specifically console_url in 4.2.

  • Add manifest for ServiceMonitor object
  • Authorize prometheus to scrape metrics from console & console-operator
    • NOTE: console disabled until we support the /metrics endpoint
  • RBAC
    • reenable delegated auth
    • add rolebinding to kube-system for
      extension-apiserver-authentication-reader for console-operatoro
    • add clusterrole system:auth-delegator to console-operator
    • allows authentication (tokenreview) and authorization
      (subjectaccessreview)
    • required as the /metrics endpoint is protected
  • mount serving-cert in operator deployment
  • add labels to namespaces to tell openshift monitoring to begin
    monitoring

- Add manifest for ServiceMonitor object
- Authorize prometheus to scrape metrics from console & console-operator
  - NOTE: console disabled until we support the /metrics endpoint
- RBAC
  - reenable delegated auth
  - add rolebinding to kube-system for
extension-apiserver-authentication-reader for console-operatoro
  - add clusterrole system:auth-delegator to console-operator
  - allows authentication (tokenreview) and authorization
(subjectaccessreview)
  - required as the /metrics endpoint is protected
- mount serving-cert in operator deployment
- add labels to namespaces to tell openshift monitoring to begin
monitoring
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@benjaminapetersen: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Expose /metrics endpoint for monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2019
- kind: ServiceAccount
name: console-operator
---
apiVersion: rbac.authorization.k8s.io/v1
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to manifests/04-rbac-rolebinding-cluster.yaml (part of original PR).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which, is not here. Going to close & reopen, the cherry-pick is missing something.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@benjaminapetersen: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-operator 0ad7119 link /test e2e-aws-operator
ci/prow/e2e-aws-upgrade 0ad7119 link /test e2e-aws-upgrade
ci/prow/images 0ad7119 link /test images
ci/prow/e2e-aws-console 0ad7119 link /test e2e-aws-console
ci/prow/e2e-aws 0ad7119 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants