OCPVE-646: add cloud credential capability #963

qJkee · 2023-09-05T14:07:58Z

No description provided.

openshift-ci-robot · 2023-09-05T14:08:01Z

@qJkee: This pull request references OCPVE-646 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

go get -u github.com/openshift/api@master go mod tidy go mod vendor git add -A go.* vendor

update tests with new capabilities brought by new version of openshift/api package

wking · 2023-12-04T23:34:39Z

I don't know if this is ready yet, because openshift/cloud-credential-operator#594 CI runs still has some CRDs associated with the capability:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cloud-credential-operator/594/pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn/1731773578577186816/artifacts/e2e-aws-ovn/gather-must-gather/artifacts/must-gather.tar | tar tvz | grep cred
-rw------- 1003680000/root  10856 2023-12-04 14:01 831f684e7f57b017401eefcd684417fcee8915173aafcdf8a54e69f76e3f93df/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/cloudcredentials.operator.openshift.io.yaml
-rw------- 1003680000/root  11252 2023-12-04 14:01 831f684e7f57b017401eefcd684417fcee8915173aafcdf8a54e69f76e3f93df/cluster-scoped-resources/apiextensions.k8s.io/customresourcedefinitions/credentialsrequests.cloudcredential.openshift.io.yaml
-rw------- 1003680000/root    986 2023-12-04 14:01 831f684e7f57b017401eefcd684417fcee8915173aafcdf8a54e69f76e3f93df/cluster-scoped-resources/apiregistration.k8s.io/apiservices/v1.cloudcredential.openshift.io.yaml
-rw------- 1003680000/root   8349 2023-12-04 14:01 831f684e7f57b017401eefcd684417fcee8915173aafcdf8a54e69f76e3f93df/cluster-scoped-resources/apiserver.openshift.io/apirequestcounts/cloudcredentials.v1.operator.openshift.io.yaml
-rw------- 1003680000/root  12828 2023-12-04 14:01 831f684e7f57b017401eefcd684417fcee8915173aafcdf8a54e69f76e3f93df/cluster-scoped-resources/apiserver.openshift.io/apirequestcounts/credentialsrequests.v1.cloudcredential.openshift.io.yaml

Maybe I don't understand how those are supposed to be annotated, and they flow in through the cluster-config-operator or other repository?

That run also still contains a namespace associated with the capability, and I don't understand that either:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cloud-credential-operator/594/pull-ci-openshift-cloud-credential-operator-master-e2e-aws-ovn/1731773578577186816/artifacts/e2e-aws-ovn/gather-extra/artifacts/namespaces.json | jq -r '.items[].metadata | select(.name | contains("cred"))'
{
  "annotations": {
    "capability.openshift.io/name": "CloudCredential",
    "openshift.io/node-selector": "",
    "openshift.io/sa.scc.mcs": "s0:c11,c10",
    "openshift.io/sa.scc.supplemental-groups": "1000130000/10000",
    "openshift.io/sa.scc.uid-range": "1000130000/10000"
  },
  "creationTimestamp": "2023-12-04T20:47:52Z",
  "labels": {
    "controller-tools.k8s.io": "1.0",
    "kubernetes.io/metadata.name": "openshift-cloud-credential-operator",
    "olm.operatorgroup.uid/1724a5ee-7ce3-4b42-9bf7-8be431027e68": "",
    "openshift.io/cluster-monitoring": "true"
  },
  "name": "openshift-cloud-credential-operator",
  "resourceVersion": "9572",
  "uid": "b98338f1-60c3-4bdb-be43-c22c6e4cd2e6"
}

wking

@qJkee figured out why those resources are there in openshift/cloud-credential-operator#594 CI. The CVO says "these manifests are labeled with a capability that isn't enabled" and ignores them. But the CCO render command says "capabilities in unset in this install-config, so I'm enabled, so include them". That should get resolved once all these pulls land.

/lgtm

openshift-ci · 2023-12-05T15:52:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qJkee · 2023-12-05T16:09:26Z

/retest

wking · 2023-12-05T18:17:52Z

HyperShift CI is generally sad, and unrelated to this pull.

/override ci/prow/e2e-hypershift

openshift-ci · 2023-12-05T18:18:09Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-hypershift

Details

In response to this:

HyperShift CI is generally sad, and unrelated to this pull.

/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qJkee · 2023-12-05T18:45:18Z

/label qe-approved
Pre merge testing ticket linked to the epic

openshift-ci-robot · 2023-12-05T18:45:36Z

@qJkee: This pull request references OCPVE-646 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2023-12-05T18:47:41Z

This always fails on cap additions, and I haven't gotten traction on openshift/api#1624.

/override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change

openshift-ci · 2023-12-05T18:47:58Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-ovn-upgrade-out-of-change

Details

In response to this:

This always fails on cap additions, and I haven't gotten traction on openshift/api#1624.

/override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2023-12-05T20:06:54Z

Override the other HyperShift job too.

/override ci/prow/e2e-hypershift-conformance

openshift-ci · 2023-12-05T20:07:10Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-hypershift-conformance

Details

In response to this:

Override the other HyperShift job too.

/override ci/prow/e2e-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2023-12-05T20:12:15Z

We expect these to fail again:

/override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change
/override ci/prow/e2e-hypershift

And these others are all expensive and unlikely to have cross-effects between this and #999 which landed in parallel:

/override ci/prow/e2e-agnostic-operator
/override ci/prow/e2e-agnostic-ovn
/override ci/prow/e2e-agnostic-ovn-upgrade-into-change

openshift-ci · 2023-12-05T20:12:37Z

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-operator, ci/prow/e2e-agnostic-ovn, ci/prow/e2e-agnostic-ovn-upgrade-into-change, ci/prow/e2e-agnostic-ovn-upgrade-out-of-change, ci/prow/e2e-hypershift

Details

In response to this:

We expect these to fail again:

/override ci/prow/e2e-agnostic-ovn-upgrade-out-of-change
/override ci/prow/e2e-hypershift

And these others are all expensive and unlikely to have cross-effects between this and #999 which landed in parallel:

/override ci/prow/e2e-agnostic-operator
/override ci/prow/e2e-agnostic-ovn
/override ci/prow/e2e-agnostic-ovn-upgrade-into-change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-12-05T20:21:02Z

@qJkee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2023-12-06T00:41:55Z

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-version-operator-container-v4.15.0-202312060008.p0.ge23ee60.assembly.stream for distgit cluster-version-operator.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 5, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023

openshift-ci bot requested review from DavidHurta and wking September 5, 2023 14:10

qJkee force-pushed the OCPVE-646 branch 2 times, most recently from 07f9501 to e347fc6 Compare October 2, 2023 15:21

qJkee force-pushed the OCPVE-646 branch 3 times, most recently from 60f889e to 35b9f59 Compare November 10, 2023 16:26

qJkee added 2 commits December 4, 2023 14:43

vendor: bump openshift/api

e510854

go get -u github.com/openshift/api@master go mod tidy go mod vendor git add -A go.* vendor

update tests with new capabilities

df1f459

update tests with new capabilities brought by new version of openshift/api package

qJkee force-pushed the OCPVE-646 branch from 35b9f59 to df1f459 Compare December 4, 2023 19:43

qJkee changed the title ~~[WIP] OCPVE-646: add cloud credential capability~~ OCPVE-646: add cloud credential capability Dec 4, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2023

wking approved these changes Dec 5, 2023

View reviewed changes

openshift-ci bot assigned wking Dec 5, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 5, 2023

openshift-merge-bot bot merged commit e23ee60 into openshift:master Dec 5, 2023

OCPVE-646: add cloud credential capability #963

OCPVE-646: add cloud credential capability #963

Uh oh!

Conversation

qJkee commented Sep 5, 2023

Uh oh!

openshift-ci-robot commented Sep 5, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wking commented Dec 4, 2023

Uh oh!

wking left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Dec 5, 2023

Uh oh!

qJkee commented Dec 5, 2023

Uh oh!

wking commented Dec 5, 2023

Uh oh!

openshift-ci bot commented Dec 5, 2023

Uh oh!

qJkee commented Dec 5, 2023

Uh oh!

openshift-ci-robot commented Dec 5, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wking commented Dec 5, 2023

Uh oh!

openshift-ci bot commented Dec 5, 2023

Uh oh!

wking commented Dec 5, 2023

Uh oh!

openshift-ci bot commented Dec 5, 2023

Uh oh!

wking commented Dec 5, 2023

Uh oh!

openshift-ci bot commented Dec 5, 2023

Uh oh!

openshift-ci bot commented Dec 5, 2023

Uh oh!

openshift-bot commented Dec 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openshift-ci-robot commented Sep 5, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 5, 2023 •

edited by openshift-ci bot

Loading