Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jul 25, 2023

Using the same process as cde8d50 (#201), but for 4.13.0:

The SVGs were generated with:

$ go build ./hack/cluster-version-util
$ mkdir /tmp/release
$ oc image extract quay.io/openshift-release-dev/ocp-release:4.13.0-x86_64[-1] --path /:/tmp/release
$ mkdir /tmp/release/manifests
$ ./cluster-version-util task-graph /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
$ ./cluster-version-util task-graph --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

$ go version
go version go1.19.5 linux/amd64
$ dot -V
dot - graphviz version 2.43.0 (0)

Using the same process as cde8d50 (docs/user/reconciliation:
Document release-image application, 2019-06-10, openshift#201), but for 4.13.0:

The SVGs were generated with:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.13.0-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util task-graph /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
  $ ./cluster-version-util task-graph --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

  $ go version
  go version go1.19.5 linux/amd64
  $ dot -V
  dot - graphviz version 2.43.0 (0)
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2023
wking added 2 commits July 25, 2023 15:49
This is from 9cf86f3 (cmd: update cmd for informers, 2018-08-14, openshift#7).
I'm not completely sure what it was about, but I expect it was a
copy/paste error referencing a MachineConfig controller.
So we can easily identify these manifests and follow up with relevant
component maintainers.

Also copy some klog handling over from cmd/main.go into
hack/cluster-version-util for static access, like:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.13.0-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util --v=4 task-graph /tmp/release 2>&1 >/dev/null | grep 'Unable to parse run level and component'
  I0725 15:53:37.900329   32072 task_graph.go:42] Unable to parse run level and component for "0000_10-helm-chart-repository.crd.yaml"
  I0725 15:53:37.900351   32072 task_graph.go:42] Unable to parse run level and component for "0000_10-project-helm-chart-repository.crd.yaml"
  I0725 15:53:37.900387   32072 task_graph.go:42] Unable to parse run level and component for "0000_10_consoleclidownload.crd.yaml"
  I0725 15:53:37.900396   32072 task_graph.go:42] Unable to parse run level and component for "0000_10_consoleexternalloglink.crd.yaml"
  ...
@wking
Copy link
Member Author

wking commented Jul 25, 2023

I've also pushed some follow-up changes around logging unmatched manifest filenames.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9c0a4ac into openshift:master Jul 26, 2023
@wking wking deleted the 4.13-task-graphs branch July 26, 2023 14:40
wking added a commit to wking/cluster-version-operator that referenced this pull request Oct 26, 2023
Using a similar process to cde8d50 (docs/user/reconciliation:
Document release-image application, 2019-06-10, openshift#201) and 4353698
(docs/user/tasks-*by-number-and-component.svg: Update to 4.13,
2023-07-25, openshift#949), but for 4.15.0-ec.1.  The SVGs were generated with
the new --granularity flag set to 'manifest', to make it easier for
cluster operator maintainers to understand how their manifests are
collected into task nodes:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.15.0-ec.1-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util task-graph --granularity manifest /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
  $ ./cluster-version-util task-graph --granularity manifest --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

  $ go version
  go version go1.21.1 linux/amd64
  $ dot -V
  dot - graphviz version 2.43.0 (0)
wking added a commit to wking/cluster-version-operator that referenced this pull request Apr 11, 2024
Using the same process as cde8d50 (docs/user/reconciliation:
Document release-image application, 2019-06-10, openshift#201) and 4353698
(docs/user/tasks-*by-number-and-component.svg: Update to 4.13,
2023-07-25, openshift#949), but for 4.15.0:

The SVGs were generated with:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.15.0-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util task-graph /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
  $ ./cluster-version-util task-graph --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

  $ go version
  go version go1.21.6 linux/amd64
  $ dot -V
  dot - graphviz version 2.43.0 (0)
wking added a commit to wking/cluster-version-operator that referenced this pull request Apr 11, 2024
Using the same process as cde8d50 (docs/user/reconciliation:
Document release-image application, 2019-06-10, openshift#201) and 4353698
(docs/user/tasks-*by-number-and-component.svg: Update to 4.13,
2023-07-25, openshift#949), but for 4.15.0.  The SVGs were generated with:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.15.0-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util task-graph /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
  $ ./cluster-version-util task-graph --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

  $ go version
  go version go1.21.6 linux/amd64
  $ dot -V
  dot - graphviz version 2.43.0 (0)
wking added a commit to wking/cluster-version-operator that referenced this pull request Aug 5, 2025
Using a similar process to cde8d50 (docs/user/reconciliation:
Document release-image application, 2019-06-10, openshift#201) and 4353698
(docs/user/tasks-*by-number-and-component.svg: Update to 4.13,
2023-07-25, openshift#949), but for 4.20.0-ec.5.  The SVGs were generated with
the new --granularity flag set to 'manifest', to make it easier for
cluster operator maintainers to understand how their manifests are
collected into task nodes:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.20.0-ec.5-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util task-graph --granularity manifest /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
  $ ./cluster-version-util task-graph --granularity manifest --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

  $ go version
  go version go1.23.6 linux/amd64
  $ dot -V
  dot - graphviz version 2.43.0 (0)
wking added a commit to wking/cluster-version-operator that referenced this pull request Aug 6, 2025
Using a similar process to cde8d50 (docs/user/reconciliation:
Document release-image application, 2019-06-10, openshift#201) and 4353698
(docs/user/tasks-*by-number-and-component.svg: Update to 4.13,
2023-07-25, openshift#949), but for 4.20.0-ec.5.  The SVGs were generated with
the new --granularity flag set to 'manifest', to make it easier for
cluster operator maintainers to understand how their manifests are
collected into task nodes:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.20.0-ec.5-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util task-graph --granularity manifest /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
  $ ./cluster-version-util task-graph --granularity manifest --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

  $ go version
  go version go1.23.6 linux/amd64
  $ dot -V
  dot - graphviz version 2.43.0 (0)
wking added a commit to wking/cluster-version-operator that referenced this pull request Aug 6, 2025
Using a similar process to cde8d50 (docs/user/reconciliation:
Document release-image application, 2019-06-10, openshift#201) and 4353698
(docs/user/tasks-*by-number-and-component.svg: Update to 4.13,
2023-07-25, openshift#949), but for 4.20.0-ec.5.  The SVGs were generated with
the new --granularity flag set to 'manifest', to make it easier for
cluster operator maintainers to understand how their manifests are
collected into task nodes:

  $ go build ./hack/cluster-version-util
  $ mkdir /tmp/release
  $ oc image extract quay.io/openshift-release-dev/ocp-release:4.20.0-ec.5-x86_64[-1] --path /:/tmp/release
  $ mkdir /tmp/release/manifests
  $ ./cluster-version-util task-graph --granularity manifest /tmp/release | dot -Tsvg >docs/user/tasks-by-number-and-component.svg
  $ ./cluster-version-util task-graph --granularity manifest --parallel flatten-by-number-and-component /tmp/release | dot -Tsvg >docs/user/tasks-flatten-by-number-and-component.svg

using:

  $ go version
  go version go1.23.6 linux/amd64
  $ dot -V
  dot - graphviz version 2.43.0 (0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants