Skip to content

explain why we cannot currently use the dnsConfig #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deads2k wants to merge 2 commits into from
Closed

explain why we cannot currently use the dnsConfig #921

deads2k wants to merge 2 commits into from

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 31, 2023

/hold

Some additional custom substitution logic could be written, but #920 may be more straight forward

deads2k added 2 commits March 29, 2023 16:14
@deads2k
Update dnsPolicy to allow consistent resolution of the internal LB
3a8ddcb 
The kubelet consistently resolves the name.  This change allows the CVO
to use the kubelet's DNS configuration.
@deads2k
explain why we cannot currently use the dnsConfig
3fea0b9
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2023
@openshift-ci openshift-ci bot requested review from DavidHurta and wking March 31, 2023 18:05
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
Once this PR has been reviewed and has the lgtm label, please assign lalatendumohanty for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2023

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@wking wking Awaiting requested review from wking

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@deads2k