Skip to content

[release-4.11] OCPBUGS-5882: Set upgradeability check throttling period to 2m #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jan 28, 2023
Merged

[release-4.11] OCPBUGS-5882: Set upgradeability check throttling period to 2m #885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/cvo/upgradeable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,16 @@ import (
const (
adminAckGateFmt string = "^ack-[4-5][.]([0-9]{1,})-[^-]"
upgradeableAdminAckRequired = configv1.ClusterStatusConditionType("UpgradeableAdminAckRequired")
checkThrottlePeriod = 2 * time.Minute
)

var adminAckGateRegexp = regexp.MustCompile(adminAckGateFmt)

// syncUpgradeable. The status is only checked if it has been more than
// the minimumUpdateCheckInterval since the last check.
// the checkThrottlePeriod since the last check.
func (optr *Operator) syncUpgradeable() error {
// updates are only checked at most once per minimumUpdateCheckInterval or if the generation changes
u := optr.getUpgradeable()
if u != nil && u.RecentlyChanged(optr.minimumUpdateCheckInterval) {
if u != nil && u.RecentlyChanged(checkThrottlePeriod) {
klog.V(2).Infof("Upgradeable conditions were recently checked, will try later.")
return nil
}
Expand Down